Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add VPN intents to alpha build #2360

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1206395221805116/f
Tech Design URL:
CC: @graeme

Description:

This PR removes app intents from non-alpha builds.

Steps to test this PR:

  1. Check that regular and alpha builds still compile
  2. Check that the widget still works in the alpha build

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from graeme January 19, 2024 20:02
@samsymons samsymons merged commit 55445fb into main Jan 23, 2024
10 checks passed
@samsymons samsymons deleted the sam/remove-app-intents-from-non-alpha-build branch January 23, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants