Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Alpha Debug build not installing NetP #2380

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

quanganhdo
Copy link
Member

Task/Issue URL: https://app.asana.com/0/1203137811378537/1206432315839131/f
Tech Design URL:
CC:

Description:

Alpha Debug build doesn’t embed PacketTunnelProvider so the VPN can’t be activated. This PR fixes this.

Steps to test this PR:

  1. Remove the VPN from Settings.app
  2. Install the Alpha Debug build using DuckDuckGo-Alpha scheme
  3. Activate the VPN
  4. Verify that it can be installed

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@quanganhdo quanganhdo requested a review from samsymons January 24, 2024 21:22
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@quanganhdo quanganhdo merged commit 459cee9 into main Jan 24, 2024
10 checks passed
@quanganhdo quanganhdo deleted the anh/netp-alpha-build-fix branch January 24, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants