Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick fix for clearing data #2400

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jan 29, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1206454582708636/f
Tech Design URL:
CC:

Description:
Defers launching a URL until data clearing has finished.

Steps to test this PR:

  1. Visit setcookie.net and set a cookie (favourite this page for speed)
  2. Check the fire button works as expected (cookie is cleared, fireproofing works)
  3. With browser set as default, launch a URL - should load correctly without any tabs closed or data cleared
  4. Remove any fireproofing for the setcookie.net
  5. Set a new cookie
  6. Enable autoclear and kill the app
  7. Launch a URL - page should load
  8. Check setcookie.net has no cookies and all tabs were closed

General smoke testing:

  1. Browse several websites
  2. Set cookies with https://www.setcookie.net
  3. Use the fire button and ensure data is cleared and app is ready to search again

@brindy brindy requested review from bwaresiak and Bunn January 29, 2024 09:46
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, description steps worked as expected.

@brindy brindy merged commit 6fb5136 into release/7.106.0 Jan 29, 2024
10 checks passed
@brindy brindy deleted the brindy/fix-navigation-errors-rebased branch January 29, 2024 11:09
@brindy brindy mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants