Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strict checking for Asana link in PR description #2463

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

jaceklyp
Copy link
Contributor

@jaceklyp jaceklyp commented Feb 9, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1206554747419422/f

Description:
This change adds GHA workflow that checks for the Asana task URL membership in iOS App Board project.
It reports failure when a task does not belong to the project and posts instructions on how to proceed.
Branch protection rules are set up to block merging when that check fails (also when Danger check fails).
Ultimately all Apple Team members are admins and will be able to circumvent the restriction, but this is
to raise awareness of the task that's linked in the description, and only allow skipping the check when
a person really knows what they're doing.

Steps to test this PR:
See detailed features list of the new workflow in the Asana task.

  1. Remove bot: not in app board label and wait for the check to re-run.
  2. Verify that it adds the label back.
  3. Go to the Asana task and add it to iOS App Board, then remove the label one more time.
  4. Verify that the check is green.

Check that this task https://app.asana.com/0/414235014887631/1206563175197670/f has been properly moved by Dax to the "Waiting for Release" section.

  1. Go to the Asana task linked in that PR and verify that Dax the Duck moved it to "Waiting for Release".

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy self-assigned this Feb 9, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Feb 9, 2024
@ayoy ayoy removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Feb 9, 2024
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks Jacek!

@ayoy ayoy assigned jaceklyp and unassigned ayoy Feb 9, 2024
@jaceklyp jaceklyp merged commit d7f7111 into main Feb 9, 2024
27 of 28 checks passed
@jaceklyp jaceklyp deleted the jacek/pr-task-url branch February 9, 2024 11:55
samsymons added a commit that referenced this pull request Feb 12, 2024
* main:
  Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2460)
  Fix HomeViewController retain cycle (#2462)
  Fix hotfixing process (#2443)
  Daniel/subscriptions/8.itp (#2427)
  Add strict checking for Asana link in PR description (#2463)
  PR test (#2464)
  swipe tabs (#2370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants