Add strict checking for Asana link in PR description #2463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1206554747419422/f
Description:
This change adds GHA workflow that checks for the Asana task URL membership in iOS App Board project.
It reports failure when a task does not belong to the project and posts instructions on how to proceed.
Branch protection rules are set up to block merging when that check fails (also when Danger check fails).
Ultimately all Apple Team members are admins and will be able to circumvent the restriction, but this is
to raise awareness of the task that's linked in the description, and only allow skipping the check when
a person really knows what they're doing.
Steps to test this PR:
See detailed features list of the new workflow in the Asana task.
bot: not in app board
label and wait for the check to re-run.Check that this task https://app.asana.com/0/414235014887631/1206563175197670/f has been properly moved by Dax to the "Waiting for Release" section.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation