Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upstream packages #2465

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Update upstream packages #2465

merged 2 commits into from
Feb 20, 2024

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Feb 9, 2024

Task/Issue URL: https://app.asana.com/0/1206264112133008/1206520782134800/f

Description:

Updates the following packages:

  • SwiftSoup
  • ZIPFoundation

Steps to test this PR:

  1. Ensure CI is green

Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Feb 9, 2024
@dus7 dus7 force-pushed the mariusz/update-packages branch from 92aa7a4 to b2279bb Compare February 9, 2024 15:29
@dus7 dus7 removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Feb 9, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Feb 9, 2024
@dus7 dus7 removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Feb 9, 2024
@dus7 dus7 marked this pull request as ready for review February 9, 2024 15:33
@samsymons samsymons self-requested a review February 19, 2024 16:44
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @dus7!

I checked each of the updated dependencies' changelogs (as best as I could anyway, SwiftSoup makes this difficult) and their usage within the app to validate that nothing is affected. Relevant behaviour seems to be working well in the simulator as well.

@dus7 dus7 merged commit ec05ac0 into main Feb 20, 2024
26 of 28 checks passed
@dus7 dus7 deleted the mariusz/update-packages branch February 20, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants