Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the tunnel monitor check interval to 1 minute #2467

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Feb 9, 2024

Task/Issue URL: https://app.asana.com/0/1203137811378537/1206567515074116/f
Tech Design URL:
CC:

Description:

Client PR for duckduckgo/BrowserServicesKit#660.

Steps to test this PR:

  1. See Increase the tunnel monitor check interval to 1 minute BrowserServicesKit#660 for steps

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Internal references:

Software Engineering Expectations
Technical Design Template

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Feb 9, 2024
# Via GitHub
* main:
  Add debug command to disable VPN (#2391)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@github-actions github-actions bot removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Feb 13, 2024
samsymons added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Feb 13, 2024
Required:

Task/Issue URL: https://app.asana.com/0/1199333091098016/1206567515074116/f
iOS PR: duckduckgo/iOS#2467
macOS PR: duckduckgo/macos-browser#2190
What kind of version bump will this require?: Patch

Description:

This PR increases the tunnel monitor check interval from 10 seconds to 1 minute.
@samsymons samsymons merged commit 85a08dd into main Feb 13, 2024
13 checks passed
@samsymons samsymons deleted the sam/increase-tunnel-monitor-check-interval branch February 13, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants