Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on demand so that it's not enabled too soon #2499

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

diegoreymendez
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1203137811378537/1206543593200557/f

Description:

Enables on-demand only after the VPN has connected.

Testing

  1. Check out BSK in a local branch and add it to the project
  2. We want to fake a connection issue that makes the connection take longer to establish, and eventually fails. To do so, replace these lines with the following code:
Task {
    try? await Task.sleep(nanoseconds: 3 * NSEC_PER_SEC)
    completionHandler(NSError(domain: "asd", code: 1))
}
  1. Run the app and try to connect the VPN.
  2. Make sure it fails after ~3 seconds, and that on-demand isn't turned ON for the connection.

If you want to see the issue that was resolved by these changes, add-back this line that was removed and repeat this test.


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@diegoreymendez diegoreymendez self-assigned this Feb 23, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Feb 23, 2024
@diegoreymendez diegoreymendez marked this pull request as ready for review February 23, 2024 19:39
@diegoreymendez diegoreymendez removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Feb 23, 2024
@diegoreymendez diegoreymendez merged commit 2700cb9 into main Feb 23, 2024
13 checks passed
@diegoreymendez diegoreymendez deleted the diego/fix-on-demand branch February 23, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants