Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local BSK reference #2529

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Remove local BSK reference #2529

merged 1 commit into from
Mar 1, 2024

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Mar 1, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1206742300407972/f
Tech Design URL:
CC:

Description:

This PR removes a local BSK reference.

Steps to test this PR:

  1. Check that CI is green
  2. Check that the project file has no local reference any more
  3. Check that the BSK tag is correct (should be the latest from here)

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested review from a team and quanganhdo and removed request for a team March 1, 2024 19:42
@samsymons samsymons merged commit fa3ca3f into main Mar 1, 2024
23 checks passed
@samsymons samsymons deleted the sam/remove-bsk-reference branch March 1, 2024 19:49
quanganhdo pushed a commit that referenced this pull request Mar 4, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1206742300407972/f
Tech Design URL:
CC:

Description:

This PR removes a local BSK reference.
quanganhdo pushed a commit that referenced this pull request Mar 4, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1206742300407972/f
Tech Design URL:
CC:

Description:

This PR removes a local BSK reference.
quanganhdo pushed a commit that referenced this pull request Mar 6, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1206742300407972/f
Tech Design URL:
CC:

Description:

This PR removes a local BSK reference.
samsymons added a commit that referenced this pull request Mar 6, 2024
# By Daniel Bernal (3) and others
# Via GitHub
* main:
  fix opening tabs with transitional (#2542)
  Integrate confirm entitlements endpoint (#2541)
  Makes dbSaveBloomFilterError daily and count (#2526)
  16. Subscription: Display "Activation in progress" message (#2535)
  Autofill support for deleting all passwords  (#2497)
  Bump BrowserServicesKit (#2532)
  Release 7.111.0-0 (#2534)
  if dax dialogs are showing then dismiss (#2506)
  Remove local BSK reference (#2529)
  15. Subscription sign-out notification observers and Design Feedback (#2528)
  Upgrade to Xcode 15.2 (#2517)
  Report Apple Ad attribution using pixel (#2510)
  15. Subscriptions: Properly sign out users and cache state (#2520)
  Check entitlement periodically and while rekeying NetP (#2461)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants