Subscription pro pixels

[federicocappelli]

Task/Issue URL: https://app.asana.com/0/1200019156869587/1205469290776415/f

Description:
Please hide whitespace changes when reviewing, this PR includes many swiftlint fixes to old code
Pixels added to all privacy pro subscription flows.

Steps to test this PR:
Please refer to https://app.asana.com/0/1205842942115003/1205469314884687/f for how to trigger the pixels
I re-run every scenario in the list above except the backend and Apple Store errors that I have no way to trigger.

--

New Pixels

Trigger	Type	Enum Value
Fires every 24 hours when subscription is active in the app	Daily pixel	privacyProSubscriptionActive
When a user navigates to the subscription offer page	Count pixel	privacyProOfferScreenImpression
When a user clicks "subscribe" in the purchase bottom sheet in the Terms & Conditions	Count Pixel + Daily Pixel	privacyProPurchaseAttempt
When the "Something Went Wrong" alert appears during purchase	Count Pixel + Daily Pixel	privacyProPurchaseFailure
When a subscription purchase fails because of a store error	Count Pixel + Daily Pixel	privacyProPurchaseFailureStoreError
When a subscription purchase fails because our BE failed	Count Pixel + Daily Pixel	privacyProPurchaseFailureBackendError
When a subscription purchase fails because our BE failed	Count Pixel + Daily Pixel	privacyProPurchaseFailureBackendError
When a subscription purchase fails because we could not create an account	Count Pixel + Daily Pixel	privacyProPurchaseFailureAccountNotCreated
When the "Your purchase was successful" alert appears	Count Pixel + Daily Pixel	privacyProPurchaseSuccess
When a user clicks "I have a subscription" ("Restore Purchase " in iOS) on the subscription offer page	Count pixel	privacyProRestorePurchaseOfferPageEntry
When a user clicks the "Enter Email" button in the Email cell in the "Activate Subscription" submenu	Count pixel + Daily Pixel	privacyProRestorePurchaseEmailStart
When a user clicks the "Restore Purchase" button in the Google Play / Apple ID cell in the "Activate Subscription" submenu	Count pixel + Daily Pixel	privacyProRestorePurchaseStoreStart
When a user successfully restores subscription using email address	Count pixel + Daily Pixel	privacyProRestorePurchaseEmailSuccess
When a user successfully restores subscription using apple store	Count pixel + Daily Pixel	privacyProRestorePurchaseStoreSuccess
When restoring subscription using Apple ID / Google Play fails because no active subscription is found in the Store	Count pixel + Daily Pixel	privacyProRestorePurchaseStoreFailureNotFound
When restoring subscription using Apple ID / Google Play fails for any reason other than no active subscription is found in the Store.	Count pixel + Daily Pixel	privacyProRestorePurchaseStoreFailureOther
When a user clicks "subscribe" in the purchase bottom sheet in the Terms & Conditions and has their subscription restored because one already exists.	Count Pixel	privacyProRestoreAfterPurchaseAttempt
When a subscription is activated for the first time in the app	Unique pixel	privacyProSubscriptionActivated
when a user clicks "Add to Another Device" in the subscriptions settings page	Count Pixel	privacyProSettingsAddDevice
when a user clicks "Add Email" in the Add Device submenu in subscription settings	Count pixel	privacyProAddDeviceEnterEmail
when a user clicks "View" for the VPN in the post-subscription onboarding flow	Unique pixel	privacyProWelcomeVPN
when a user clicks "View" for PIR in the post-subscription onboarding flow	Unique pixel	privacyProWelcomePersonalInformationRemoval
when a user clicks "View" for IDTR in the post-subscription onboarding flow	Unique pixel	privacyProWelcomeIdentityRestoration
when a user clicks the button to access Subscription Settings on the settings page, after their subscription is active	Count pixel	privacyProSubscriptionSettings
when a user clicks the button to access the VPN on the settings page, after their subscription is active	Count pixel	privacyProVPNSettings
when a user clicks the button to access PIR on the settings page, after their subscription is active	Count pixel	privacyProPersonalInformationRemovalSettings
when a user clicks the button to access IDTR on the settings page, after their subscription is active	Count pixel	privacyProIdentityRestorationSettings
User clicks the edit button on the "manage email" submenu	Count pixel	privacyProSubscriptionManagementEmail
User clicks "change plan or billing" on the subscription settings menu	Count pixel	privacyProSubscriptionManagementPlanBilling
User clicks "remove subscription" button in alert	count pixel	privacyProSubscriptionManagementRemoval

[github-actions]

	Warnings
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against c607de4

[afterxleep]

@federicocappelli

Code looks fine, but I left a few questions about Daily pixels and some recommendations on moving some of the calls to the ViewModel.

While I can run every feature scenario, I don't have enough context to understand which pixels should fire in every case and when.- While the code looks mostly fine to me, If you want me to test this in detail, I'll need detailed instructions on where in the process each pixel should be fired. (I don't necessarily have enough context on the project and discussions to infer this)

[afterxleep]

@federicocappelli I updated the description to add the pixel list as a quick table so it's quick to review/validate. This may also be useful for the macOS part.

[afterxleep]

@federicocappelli It seems some pixels are not correct when restoring a subscription.

I did this:

1. Open the app
2. Go to settings
3. Tap I have A subscription
4. Tap Restore (With no subscription)
5. Get error "Subscription Not found"

I'm seeing duplicate pixels fired, as well as several failures that shouldn't be fired here.

These pixels were fired.
✅ - Pixel fired m_privacy-pro_offer_screen_impression [:]
⚠️ - Pixel fired m_privacy-pro_settings_add-device_click [:]
⚠️ - Pixel fired m_privacy-pro_settings_add-device_click [:]
✅ - Pixel fired m_privacy-pro_activate-subscription_restore-purchase_click_c [:]
⚠️ - Pixel fired m_privacy-pro_activate-subscription_restore-purchase_click_d [:]
⚠️ - Pixel fired m_privacy-pro_app_subscription-purchase_failure_other_c [:]
⚠️ - Pixel fired m_privacy-pro_app_subscription-purchase_failure_other_d [:]
⚠️ - Pixel fired m_privacy-pro_app_subscription-purchase_failure_store_c [:]
⚠️ - Pixel fired m_privacy-pro_app_subscription-purchase_failure_store_d [:]
⚠️ - Pixel fired m_privacy-pro_app_subscription-restore-using-store_failure_other_c [:]
⚠️ - Pixel fired m_privacy-pro_app_subscription-restore-using-store_failure_other_d [:]

[afterxleep]

Cancelling the purchase, fires this twice.

• Select a subcription
• Tap purchase
• Cancel the apple dialog.

- Pixel fired m_privacy-pro_app_subscription-purchase_failure_store_c [:]
- Pixel fired m_privacy-pro_app_subscription-purchase_failure_other_c [:]

[afterxleep]

Code looks ok, but I still see some duplicate pixels and misfires. Let's get this merged to prevent more conflicts and iterate on that later