Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix history debug view controller causing crash on tap #2681

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Apr 4, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1207004361509202/f
Tech Design URL:
CC:

Description:
Fixes crash when tapping on history debug view controller.

Steps to test this PR:

  1. Access the history debug option from Settings > Debug > History
  2. Should not crash

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Apr 4, 2024
@brindy brindy removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Apr 4, 2024
@brindy brindy requested a review from quanganhdo April 4, 2024 23:20
@brindy brindy merged commit 8d4fbda into main Apr 5, 2024
22 of 23 checks passed
@brindy brindy deleted the brindy/fix-history-debug-item branch April 5, 2024 08:18
samsymons added a commit that referenced this pull request Apr 7, 2024
# By Christopher Brind (2) and others
# Via GitHub
* main:
  Use trait collection to control theme changes (#2672)
  Expand maestro tests (#2691)
  scroll to selected item after opening new tab, etc (#2689)
  Update autoconsent to v10.5.0 (#2671)
  Fix history debug view controller causing crash on tap (#2681)

# Conflicts:
#	DuckDuckGo/HomeCollectionView.swift
#	DuckDuckGo/HomeViewController.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants