Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maestro: hide dax dialogs if visible and cancel keyboard after fireproof #2695

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Apr 8, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1207014419221336/f
Tech Design URL:
CC:

Description:
Improves the stability of the fire proofing end to end test. Adds short cut to hide dax dialogs.

Steps to test this PR:

  1. Run the test locally
  2. Admire the passing state of the tests here https://github.com/duckduckgo/iOS/actions/runs/8599167350/job/23561488619

@brindy brindy changed the title hide dax dialogs if visible and cancel keyboard after fireproof maestro: hide dax dialogs if visible and cancel keyboard after fireproof Apr 8, 2024
@brindy brindy marked this pull request as ready for review April 8, 2024 15:18
@brindy brindy requested a review from loremattei April 8, 2024 15:18
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brindy brindy merged commit d8673d0 into main Apr 12, 2024
24 checks passed
@brindy brindy deleted the brindy/fix-fireproofing-maestro-test branch April 12, 2024 08:37
samsymons added a commit that referenced this pull request Apr 15, 2024
# By Daniel Bernal (33) and others
# Via Mariusz Śpiewak (5) and others
* main: (245 commits)
  Fix inconsistent bars state when scrolling (#2733)
  fix tests (#2732)
  Release 7.115.0-4 (#2729)
  Fix VPN denial prompt loop (#2728)
  Small UI Fixes for subscriptions (#2690)
  SPM updated: SwiftSoup, Lottie, ZIPFoundation (#2724)
  Release 7.115.0-3 (#2727)
  VPN: Specific TunnelController start failure reporting (#2714)
  update bsk dependency (#2725)
  Subscriptions: Fix thread issue on Subscription Restore (#2719)
  Manage ‘Stale’ PRs (#2723)
  maestro: hide dax dialogs if visible and cancel keyboard after fireproof (#2695)
  Remove timezone offset from the VPN server object (#2701)
  Reverting accidental push to main (#2718)
  Add SubscriptionContainerViewModel and
  Manually hide loader + Pixel (#2687)
  Release 7.115.0-2 (#2712)
  soft revert history suggestions (#2711)
  Bring back accessibility identifiers for onboarding buttons (#2709)
  BSK release 133.1.0 (#2708)
  ...

# Conflicts:
#	Core/Pixel.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants