Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to ensure that page refresh doesn't affect url bar focus #2749

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

bwaresiak
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/0/1207004088983506/f
Tech Design URL:
CC:

Description:

Add test to ensure URL bar doesn't lose focus on site refresh.

Steps to test this PR:

Run the tests to make sure these pass.


Internal references:

Software Engineering Expectations
Technical Design Template

@bwaresiak bwaresiak requested a review from loremattei April 16, 2024 08:46
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Apr 16, 2024
@bwaresiak bwaresiak removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Apr 16, 2024
Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small and very minor suggestion.
LGTM!
Thanks for adding this!

# search_bar.yaml
appId: com.duckduckgo.mobile.ios
tags:
- release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial plan was to keep tags aligned to folders to make it clearer what was running at any point. It looks like we've already lost this over time, so this is likely fine at this point.

visible:
text: "This is just a text that will be never matched so this invocation will cause 5s delay"
index: 0
file: onboarding_browsing.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything is fine here obviously. I'm just wondering if something like

commands: 
  - stopApp: appId

would make intentions clearer here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've tweaked the command

@bwaresiak bwaresiak merged commit bc981c7 into main Apr 18, 2024
13 checks passed
@bwaresiak bwaresiak deleted the bartek/more-maestro branch April 18, 2024 14:34
samsymons added a commit that referenced this pull request Apr 20, 2024
# By Daniel Bernal (11) and others
# Via Mariusz Śpiewak (3) and others
* main: (63 commits)
  Release 7.115.1-1 (#2770)
  Fix iOS auto-clearing fails to remove cookies (#2769)
  Release 7.115.1-0 (#2768)
  Fix iOS auto-clearing fails to remove cookies (#2767)
  iOS: VPN screen improvements (#2721)
  Release 7.116.0-2 (#2763)
  Remove "Thank You" prompt (#2762)
  Test to ensure that page refresh doesn't affect url bar focus (#2749)
  Add support for uploading crash reports to Sentry (#2720)
  Replace SwiftLintPlugin with SwiftLintTool (#2710)
  Release 7.116.0-1 (#2761)
  Remove validator app (#2754)
  Fix crash when quickly adding/removing tabs in switcher (#2760)
  Fix settings navigation bar colors after reopening (#2758)
  Alpha ad-hoc lane (#2492)
  Keep a weak reference to UserScriptMessageBroker (#2755)
  Add refresh config cell to top of debug (#2735)
  VPN: Replace available interfaces in VPN metadata (#2750)
  Require device auth to be set in order to use Sync (#2722)
  Add new iOS pixels for measuring navigation  (#2730)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo/AppDelegate.swift
#	DuckDuckGo/MainViewController.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants