Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't refresh swipe tabs data source if autoclearing #2960

Merged
merged 1 commit into from
Jun 17, 2024
Merged

don't refresh swipe tabs data source if autoclearing #2960

merged 1 commit into from
Jun 17, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Jun 17, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1207578201865177/f
Tech Design URL:
CC:

Description:
Fix problem showing keyboard if auto clear and show keyboard on app launch is set

Steps to test this PR:

  1. Turn on auto clear after 5 minutes and turn on keyboard on app launch
  2. Update shouldClearData Autoclear.swift so that 5 minutes is just 5 seconds
  3. Load a page
  4. Kill the app
  5. Launch the app
  6. Data should be cleared and keyboard should show (remember if you're in the simulator to make sure it's visible by default and that using the hardware keyboard will dismiss it)
  7. Load another page
  8. Background the app and wait for > 20 seconds (the threshold for the keyboard on app launch is is 20 seconds)
  9. Foreground the app
  10. Data should be cleared and the keyboard should show
  11. Smoke test regular data clearing activities

@brindy brindy requested review from bwaresiak and graeme June 17, 2024 12:09
graeme
graeme approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@graeme graeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@brindy brindy merged commit 631939b into main Jun 17, 2024
22 checks passed
@brindy brindy deleted the brindy/fix-keyboard-on-launch-and-clear-bug branch June 17, 2024 13:33
samsymons added a commit that referenced this pull request Jun 17, 2024
@samsymons
Merge branch 'main' into sam/vpn-reddit-cookie-workaround
364c93d 
* main:
  don't refresh swipe tabs data source if autoclearing (#2960)
  Fall back to accentColor for iOS 15 and below (#2952)
samsymons added a commit that referenced this pull request Jun 20, 2024
@samsymons
Merge branch 'main' into sam/sub-access-token-throws
2617aa1 
# By Mariusz Śpiewak (4) and others
# Via GitHub (1) and others
* main:
  Additional Autofill KPI pixels (#2943)
  Prevent duplicate attribution (#2956)
  Release 7.125.0-2 (#2969)
  Disable ad attribution reporting (#2968)
  Fix haptic feedback for refresh control (#2942)
  Release 7.125.0-1 (#2966)
  Add two more pixels to the dashboard experiment (#2963)
  VPN state workarounds (#2938)
  RMF: New "Interacted With Message" matching attribute (#2947)
  Release 7.125.0-0 (#2962)
  don't refresh swipe tabs data source if autoclearing (#2960)
  Fall back to accentColor for iOS 15 and below (#2952)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graeme graeme graeme approved these changes

@bwaresiak bwaresiak Awaiting requested review from bwaresiak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brindy @graeme