Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes goBack() behavior #2996

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fixes goBack() behavior #2996

merged 1 commit into from
Jun 26, 2024

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Jun 26, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414709148257752/1207663375808651/f

Description:

  • Fixes an issue caused by incomplete logic for the goBack() behavior when implementing DuckPlayer
  • Cleans up the goBack() method for clarity and early returns (remove if/else)

Steps to test this PR:

  1. Navigate to https://privacy-test-pages.site/
  2. Click "Link Open In a New Window" from Browser Features Section
  3. Click "Opens in new Window"
  4. Hit the "Back button"
  5. Confirm the tab is closed and you're back int he previous one. (Only two tabs are open)

Alternatively, run maestro tests for browser features:

➜ iOS git:(main) maestro test .maestro/browser_features

Running on iPhone (17.4) - iOS 17.4 - D1F122BF-1A9D-4B6B-9AD9-A6F088DD51A0

Waiting for flows to complete...

[Passed] search_bar (53s)
[Passed] opening_tabs (58s)
[Passed] swipe_tabs (47s)

3/3 Flows Passed in 2m 38s
Internal references:

Software Engineering Expectations
Technical Design Template

@afterxleep afterxleep marked this pull request as ready for review June 26, 2024 11:52
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 26, 2024
@afterxleep afterxleep removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 26, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 26, 2024
@afterxleep afterxleep requested review from dus7 and bwaresiak June 26, 2024 11:59
@afterxleep afterxleep removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 26, 2024
@github-actions github-actions bot added bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project and removed bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project labels Jun 26, 2024
dus7
dus7 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@dus7 dus7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified the scenario works and tests are passing.

@afterxleep afterxleep merged commit 100cf9f into release/7.126.0 Jun 26, 2024
35 of 40 checks passed
@afterxleep afterxleep deleted the daniel/e2e.issue.fix branch June 26, 2024 12:20
@afterxleep afterxleep restored the daniel/e2e.issue.fix branch June 26, 2024 12:40
samsymons added a commit that referenced this pull request Jun 27, 2024
@samsymons
Merge branch 'main' into sam/silence-tunnel-startup-noise-without-acc…
9b490c9 
…ess-token

# By Christopher Brind (3) and others
# Via Chris Brind (1) and GitHub (1)
* main:
  Update VPN metadata to include entitlement (#3002)
  Remove noise from wake pixel (#2986)
  Release 7.126.0-1 (#2998)
  [DuckPlayer] - 2. Overlay Views (#2989)
  update translations for autocomplete settings changes (#2995)
  Fixes goBack() behavior (#2996)
  Re-add the autocomplete settings toggle pixels (#2991)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Jul 4, 2024
@samsymons
Merge branch 'main' into sam/vpn-snooze-initial-support
5bb79dc 
* main:
  Update VPN metadata to include entitlement (#3002)
  Remove noise from wake pixel (#2986)
  Release 7.126.0-1 (#2998)
  [DuckPlayer] - 2. Overlay Views (#2989)
  update translations for autocomplete settings changes (#2995)
  Fixes goBack() behavior (#2996)
  Re-add the autocomplete settings toggle pixels (#2991)
  Update BSK with autofill 12.0.1 (#2983)
  Final batch of new autofill pixels (#2977)
  don't attach a new home screen if autoclear is in progress (#2988)
  Custom DNS for VPN (#2971)
  Duck Player settings page (#2990)
  Add feature flag for improved New Tab Page  (#2980)
@afterxleep afterxleep deleted the daniel/e2e.issue.fix branch October 8, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dus7 dus7 dus7 approved these changes

@bwaresiak bwaresiak Awaiting requested review from bwaresiak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afterxleep @dus7