Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix index out-of-bounds in startAttachingCrashLogMessages #3123

Merged
merged 3 commits into from
Jul 23, 2024
Merged

fix index out-of-bounds in startAttachingCrashLogMessages #3123

merged 3 commits into from
Jul 23, 2024

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Jul 23, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414709148257752/1207877553454228/f
BSK PR: duckduckgo/BrowserServicesKit#906

Description:

  • Fixes Out-of-bounds exception when no records in crashDiagnostics array
  • Rollback crash collection in C++ exception handler

Steps to test this PR:

  1. Simulate a crash in App Store target with debugger detached
  2. Set a breakpoint at CrashCollection.swift:122 and remove items from crashDiagnostics array (using LLDB: po crashDiagnostics.removeAll())
  3. validate the code is not crashing when adding a record to the array

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@mallexxx mallexxx requested a review from brindy July 23, 2024 13:13
@mallexxx mallexxx changed the title set BSK rev fix index out-of-bounds in startAttachingCrashLogMessages Jul 23, 2024
@github-actions GitHub Actions
Copy link

🚫 The Asana task linked in the PR description is not added to iOS App Board project.

  1. Verify that the correct task is linked in the PR.
    • ⚠️ Please use the actual implementation task, rather than the Code Review subtask.
  2. Verify that the task is added to iOS App Board project.
  3. When ready, remove the bot: not in app board label to retrigger the check.

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jul 23, 2024
@brindy brindy changed the base branch from hotfix/7.129.0-0 to hotfix/7.129.1 July 23, 2024 13:32
mallexxx added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 23, 2024
@mallexxx
Hotfix: fix index out-of-bounds in startAttachingCrashLogMessages (#906)
8adaa84 
Task/Issue URL: https://app.asana.com/0/414709148257752/1207877553454228/f
iOS PR: duckduckgo/iOS#3123
brindy
brindy approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs!

@brindy brindy merged commit 8fd9df6 into hotfix/7.129.1 Jul 23, 2024
10 of 11 checks passed
@brindy brindy deleted the hotfix/7.129.0-0-fix-crash-diagnostics-oob branch July 23, 2024 14:29
bwaresiak pushed a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 23, 2024
@mallexxx @bwaresiak
Hotfix: fix index out-of-bounds in startAttachingCrashLogMessages (#906)
13aadd2 
Task/Issue URL: https://app.asana.com/0/414709148257752/1207877553454228/f
iOS PR: duckduckgo/iOS#3123
bwaresiak pushed a commit that referenced this pull request Jul 23, 2024
@mallexxx @bwaresiak
fix index out-of-bounds in startAttachingCrashLogMessages (#3123)
8c2e22e 
Task/Issue URL: https://app.asana.com/0/414709148257752/1207877553454228/f
BSK PR: duckduckgo/BrowserServicesKit#906

Description:

Fixes Out-of-bounds exception when no records in crashDiagnostics array
Rollback crash collection in C++ exception handler
Steps to test this PR:

Simulate a crash in App Store target with debugger detached
Set a breakpoint at CrashCollection.swift:122 and remove items from crashDiagnostics array (using LLDB: po crashDiagnostics.removeAll())
validate the code is not crashing when adding a record to the array
bwaresiak added a commit that referenced this pull request Jul 24, 2024
@bwaresiak
Internal update for: fix index out-of-bounds in startAttachingCrashLo…
8eb8484 
…gMessages (#3123) (#3128)

Task/Issue URL: https://app.asana.com/0/856498667320406/1207870107815713/f
Tech Design URL:
CC:

Description:

Update internal release after recent hotfix.

BSK ref: https://github.com/duckduckgo/BrowserServicesKit/releases/tag/174.0.1-1
samsymons added a commit that referenced this pull request Jul 24, 2024
@samsymons
Merge branch 'main' into sam/ios-14-cleanup
e497ecb 
# By Daniel Bernal (6) and others
# Via Chris Brind (3) and others
* main: (24 commits)
  [DuckPlayer] 10 . Move DuckPlayer init to TabManager (#3124)
  Fix threading issue with Mesage broker (#3132)
  [Duckplayer] - 9. Edge Cases (#3115)
  Release 7.130.0-2 (#3134)
  Internal update for: fix index out-of-bounds in startAttachingCrashLogMessages (#3123) (#3128)
  Attach params to PPro pixels (#3092)
  Don't show key icon for empty passwords (#3070)
  Release 7.129.1-0 (#3127)
  fix index out-of-bounds in startAttachingCrashLogMessages (#3123)
  Release 7.130.0-1 (#3122)
  Revert old Dax icon for old onboarding (#3085)
  Scroll to Internal User setting (#3114)
  Release 7.130.0-0 (#3118)
  Allow activating subscription for internal users via debug menu (#3117)
  Update breakage report locale to JSON format (#3112)
  [Duckplayer] 8. Age restricted videos (#3111)
  Reduce VPN manager instances (#3097)
  Update BSK for Mac RMF changes (#3107)
  [DuckPlayer] 7- Open Settings (#3110)
  [DuckPlayer] 6 - Init updates and Watch on YouTube (#3066)
  ...

# Conflicts:
#	DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandler.swift
samsymons added a commit that referenced this pull request Jul 25, 2024
@samsymons
Merge branch 'main' into sam/vpn-snooze-initial-support
19b9362 
# By Daniel Bernal (4) and others
# Via Chris Brind (3) and others
* main:
  [DuckPlayer] 10 . Move DuckPlayer init to TabManager (#3124)
  Fix threading issue with Mesage broker (#3132)
  [Duckplayer] - 9. Edge Cases (#3115)
  Release 7.130.0-2 (#3134)
  Internal update for: fix index out-of-bounds in startAttachingCrashLogMessages (#3123) (#3128)
  Attach params to PPro pixels (#3092)
  Don't show key icon for empty passwords (#3070)
  Release 7.129.1-0 (#3127)
  fix index out-of-bounds in startAttachingCrashLogMessages (#3123)
  Release 7.130.0-1 (#3122)
  Revert old Dax icon for old onboarding (#3085)
  Scroll to Internal User setting (#3114)
  Release 7.130.0-0 (#3118)
  Allow activating subscription for internal users via debug menu (#3117)
  Update breakage report locale to JSON format (#3112)
  [Duckplayer] 8. Age restricted videos (#3111)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy brindy approved these changes

Assignees
No one assigned
Labels
bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallexxx @brindy