Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated macOS VPN Domain exclusion (internal release) changes into iOS. #3164

Merged
merged 9 commits into from
Aug 5, 2024

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Jul 30, 2024

Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f

BSK PR: duckduckgo/BrowserServicesKit#918
macOS PR: duckduckgo/macos-browser#3045

Description

Integrates latest macOS BSK changes for supporting domain exclusions.

Testing

Ensure the VPN works well and check that nothing is broken.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@diegoreymendez diegoreymendez changed the title VPN Domain exclusions (internal release) Integrated macOS VPN Domain exclusion (internal release) changes into iOS. Jul 31, 2024
@diegoreymendez diegoreymendez marked this pull request as ready for review July 31, 2024 15:43
@diegoreymendez diegoreymendez requested a review from samsymons July 31, 2024 15:43
diegoreymendez added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 5, 2024
Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f

iOS PR: duckduckgo/iOS#3164
macOS PR: duckduckgo/macos-browser#3045

What kind of version bump will this require?: Patch

## Description

Adds BSK support for implements domain exclusions in macOS for internal
users only.
@diegoreymendez diegoreymendez merged commit cca5220 into main Aug 5, 2024
13 checks passed
@diegoreymendez diegoreymendez deleted the diego/exclude-domains branch August 5, 2024 20:34
diegoreymendez added a commit to duckduckgo/macos-browser that referenced this pull request Aug 5, 2024
Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f

BSK PR: duckduckgo/BrowserServicesKit#918
iOS PR: duckduckgo/iOS#3164

## Description

Implements domain exclusions for internal users only.
diegoreymendez added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Aug 6, 2024
Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f

iOS PR: duckduckgo/iOS#3164
macOS PR: duckduckgo/macos-browser#3045

What kind of version bump will this require?: Patch

## Description

Adds BSK support for implements domain exclusions in macOS for internal
users only.
diegoreymendez added a commit that referenced this pull request Aug 6, 2024
… iOS. (#3164)

Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f

BSK PR: duckduckgo/BrowserServicesKit#918
macOS PR: duckduckgo/macos-browser#3045

## Description

Integrates latest macOS BSK changes for supporting domain exclusions.
diegoreymendez added a commit to duckduckgo/macos-browser that referenced this pull request Aug 6, 2024
Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f

BSK PR: duckduckgo/BrowserServicesKit#918
iOS PR: duckduckgo/iOS#3164

## Description

Implements domain exclusions for internal users only.
samsymons added a commit that referenced this pull request Aug 7, 2024
# By Mariusz Śpiewak (7) and others
# Via Diego Rey Mendez (1) and GitHub (1)
* main:
  Bump BSK to 181.1.0 (sets Privacy Dashboard to 5.0.0) (#3166)
  Animate transition between New Tab Page and tab switcher (#3196)
  Fix New Tab Page UI issues on iOS 15 (#3198)
  Push domain exclusions to internal release (#3195)
  Show shortcuts for enabled features only (#3193)
  Translate strings introduced in New Tab Page improvements (#3174)
  Update release workflow to use S3 bucket name from secrets (#3120)
  Handle contingency settings state on remote config (#3190)
  Add UI for displaying Duck Player contingency message #3065 (#3181)
  Open keyboard on New Tab Page based on Settings (#3187)
  Integrated macOS VPN Domain exclusion (internal release) changes into iOS. (#3164)
  Release 7.132.0-0 (#3194)
  Increase testPixelDebouncePreventsFiringWithinInterval test timeout (#3192)
  Update toolbar items for New Tab Page (#3185)
  new pixel and parameter for monitoring clearing of data stores (#3186)
  ensure new data clearing api is being used (#3191)
  If no App Store subscriptions option are available return empty options object (#3188)
  Show Intro message for existing users on New Tab Page (#3173)
  Experiment Contextual onboarding (#3160)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants