Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failure to shut down VPN when subscription expires #3237

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Fix failure to shut down VPN when subscription expires #3237

merged 2 commits into from
Aug 14, 2024

Conversation

quanganhdo
Copy link
Member

Task/Issue URL: https://app.asana.com/0/414709148257752/1208033535142062/f
Tech Design URL:
CC:

Description:

Steps to test this PR:
1.
2.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@quanganhdo quanganhdo changed the base branch from main to release/7.133.0 August 14, 2024 19:13
@quanganhdo quanganhdo marked this pull request as ready for review August 14, 2024 19:13
@quanganhdo quanganhdo requested a review from afterxleep August 14, 2024 19:13
@quanganhdo quanganhdo merged commit 07a1dec into release/7.133.0 Aug 14, 2024
8 of 9 checks passed
@quanganhdo quanganhdo deleted the anh/ppro/fix-shutdown-again branch August 14, 2024 19:23
samsymons added a commit that referenced this pull request Aug 15, 2024
@samsymons
Merge branch 'release/7.133.0' into sam/adattributionkit-support
165baf9 
* release/7.133.0:
  Release 7.133.0-1 (#3238)
  Fix failure to shut down VPN when subscription expires (#3237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afterxleep afterxleep afterxleep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quanganhdo @afterxleep