Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixels for new Sync promos #3269

Merged

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Aug 22, 2024

Task/Issue URL: https://app.asana.com/0/1142021229838617/1208017419957479/f
Tech Design URL:
CC:

Description:
Pixels for the new Sync Promo feature + new platform links in Sync screen

Steps to test this PR:

  1. Disable Sync if it’s enabled & ensure at least 1 bookmark & 1 password is saved
  2. Visit the Passwords screen and confirm this pixel fires: sync.promotion.displayed ["source": “password”]
  3. Tap “Set Up Sync” in the promo & confirm this pixel fires: sync.promotion.confirmed ["source": "passwords”]
  4. Go back to the Passwords screen and tap the “No Thanks” button on the promo & confirm this pixel fires: sync.promotion.dismissed ["source": "passwords”]
  5. Visit the Bookmarks screen and repeat steps 2 -4, confirming that this time the pixel source is bookmarks
  6. Reset the Sync Promos via the debug menu (last entry on the main debug screen)
  7. Go to Passwords, tap “Set Up Sync” and from the Sync screen select “Sync and Back Up This Device” and complete the setup flow.
  8. Confirm this pixel fires with promotion_passwords as the source: m.sync.signup.direct ["source": "promotion_passwords”]
  9. Disable Sync and repeat from the Bookmarks screen.
  10. Confirm this pixel fires with promotion_bookmarks as the source: m.sync.signup.direct ["source": "promotion_bookmarks”]
  11. Disable Sync again and back out of the Sync screen, then come back in
  12. Select “Sync and Back Up This Device” again and confirm m.sync.signup.direct fires without the “source” parameter
  13. Disable Sync and repeat steps 7 - 12, except this time set up sync with another device and checking instead for the pixel m.sync.signup.connect
  14. Disable Sync, and from the Sync screen select Get DuckDuckGo on other Devices.
  15. Confirm this pixel fires: sync.get.other.devices ["source": "not_activated”]
  16. Tap the link & copy to clipboard. Confirm this pixel fires: sync.get.other.devices.copy ["source": "not_activated”]
  17. Tap the share action and confirm this pixel fires: sync.get.other.devices.share ["source": "not_activated”]
  18. Set up Sync (again, sorry! can be as a backup) and on the “Your data is synced” screen tap Get DuckDuckGo on other Devices instead of Done.
  19. Repeat steps 15 - 17, where the same pixels should fire but with source = activating
  20. Go back to the Sync screen and select Get DuckDuckGo on other Devices
  21. Repeat steps 15 - 17, where the same pixels should fire but with source = activated

<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
—>

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 marked this pull request as ready for review August 23, 2024 13:48
@amddg44 amddg44 requested a review from aataraxiaa August 23, 2024 13:57
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good @amddg44 . Only one thing - I could not get step 16, the “copy” pixel, to fine. Not results when filtering the console for ‘“copy”.

Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed and resolve pixel issue on MM with @amddg44 .

@amddg44 amddg44 merged commit 749cb0f into anya/sync-touchpoints-promotion Aug 28, 2024
26 checks passed
@amddg44 amddg44 deleted the anya/sync-touchpoints-promo-pixels branch August 28, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants