Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1142021229838617/1208017419957479/f
Tech Design URL:
CC:
Description:
Pixels for the new Sync Promo feature + new platform links in Sync screen
Steps to test this PR:
sync.promotion.displayed ["source": “password”]
sync.promotion.confirmed ["source": "passwords”]
sync.promotion.dismissed ["source": "passwords”]
bookmarks
promotion_passwords
as the source:m.sync.signup.direct ["source": "promotion_passwords”]
promotion_bookmarks
as the source:m.sync.signup.direct ["source": "promotion_bookmarks”]
m.sync.signup.direct
fires without the “source” parameterm.sync.signup.connect
Get DuckDuckGo on other Devices
.sync.get.other.devices ["source": "not_activated”]
sync.get.other.devices.copy ["source": "not_activated”]
sync.get.other.devices.share ["source": "not_activated”]
Get DuckDuckGo on other Devices
instead of Done.activating
Get DuckDuckGo on other Devices
activated
<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.
Using a simulator where a physical device is unavailable is acceptable.
—>
Definition of Done (Internal Only):
Copy Testing:
’
rather than’
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template