Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DuckPlayer] 26. Fix saved favs when DuckPlayer is disabled #3285

Merged
merged 24 commits into from
Aug 29, 2024
Merged

[DuckPlayer] 26. Fix saved favs when DuckPlayer is disabled #3285

merged 24 commits into from
Aug 29, 2024

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Aug 28, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1204051006248674/1208166085652228/f
Tech Design URL:
CC:

Description:

  • Fix saved favorites when DuckPlayer is disabled

Steps to test this PR:

This change is covered by a unit test. For manual validation, do as follows:

  • Make yourself internal user
  • Add a custom privacy conflig from https://www.jsonblob.com/api/1276215786342309888
  • Enable Duck Player
  • Go to youtube.com, search for something and tap on a video to Watch in Duck Player
  • While in Duck Player add the video to favorites
  • Close the tab
  • Go to your favorites and open the last one you added.
  • Confirm it loads in DuckPlayer
  • Close the tab
  • Disable DuckPlayer from Settings > Duck Player
  • Go to your favorites, and open the last saved favorite
  • Confirm it loads in Youtube

@afterxleep
Fix Close tab with back button
174a172
@afterxleep
Add tests
c1f7586
@afterxleep
Update tab Link to use duck:// scheme if needed
1374ef0
@afterxleep
Updated Build settings
52b5882
@afterxleep
Merge branch 'main' into daniel/duckplayer/23.bug.fixes.1
3cdb17d
@afterxleep
Attempt to open in the Youtube app if user has requested it
0035855
@afterxleep
Fix whitespace
ee2a57f
@afterxleep
Only go back to non-youtube items when DP is enabled
b56d8d7
@afterxleep
Merge branch 'main' into daniel/duckplayer/23.bug.fixes.1
7d18dc9
@afterxleep
Add translations for DuckPlayer FE
b174419
@afterxleep
Move to constants
2f22f94
@afterxleep
Update tests to include appSettings
9de3ad9
@afterxleep
Updated strings
dfcc532
@afterxleep
Fix JSON extension and make var private
a5b20de
@afterxleep
Remove C.S.S
efdca2e
@afterxleep
Allow message origin for www.youtube.com
d04cd3d
@afterxleep
Update string to use constant and remove dupe
1c8c489
@afterxleep
Merge branch 'daniel/duckplayer/23.bug.fixes.1' into daniel/duckplaye…
d6dca9a 
…r/26.fix.favorites.save

# Conflicts:
#	DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandler.swift
@afterxleep
Saved favorites redirect properly when DP is disabled
78c14f6
@afterxleep afterxleep requested a review from Bunn August 28, 2024 12:36
@afterxleep afterxleep changed the title Daniel/duckplayer/26.fix.favorites.save [DuckPlayer] 26. Fix saved favs when DuckPlayer is disabled Aug 28, 2024
Bunn
Bunn approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afterxleep afterxleep merged commit 4649c38 into main Aug 29, 2024
13 checks passed
@afterxleep afterxleep deleted the daniel/duckplayer/26.fix.favorites.save branch August 29, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bunn Bunn Bunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afterxleep @Bunn