Update BSK version to support userTips NetP Flag #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
approved these changes
Oct 8, 2024
Bunn
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Oct 8, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1208381891916914/f iOS PR: duckduckgo/iOS#3416 macOS PR: duckduckgo/macos-browser#3365 What kind of version bump will this require?: Minor **Description**: Add userTips feature flag
samsymons
added a commit
that referenced
this pull request
Oct 9, 2024
* main: Update BSK version to support userTips NetP Flag (#3416) Release 7.140.0-0 (#3418) Adds new debug screen to view raw credentials data (#3400) Bump rollup from 2.79.1 to 3.29.5 (#3385) fix UI tests broken by tabs suggestions (#3402) Fix ability to edit Synced device name (#3404) Fix failing password-management maestro test (#3413)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1208381891916914/f
Tech Design URL:
CC:
Description:
Update BSK version to support userTips NetP Flag
Steps to test this PR:
print("USER ON? \(AppDependencyProvider.shared.featureFlagger.isFeatureOn(.networkProtectionUserTips))")to the App Delegate and check if the flag is returning as true (it should)isFeatureOnfunction returns false