Merge Hotfix/7.141.1 into 7.142.0 release branch #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nload)` (#3478) Task/Issue URL: https://app.asana.com/0/414709148257752/1208621179920770/f **Description:** When navigation should trigger download and is of data scheme handle it via decisionHandler(.download) **Steps to test this PR:** - test downloads on https://napuzba.com/data-url/ (ensure proper file name and extension) - test website from https://app.asana.com/0/1206777341262243/1208605967462508/f following repro steps in https://app.asana.com/0/0/1208605967462508/1208619416618129/f **Definition of Done (Internal Only)**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? **Copy Testing**: * [ ] Use of correct apostrophes in new copy, ie `’` rather than `'` **Orientation Testing**: * [ ] Portrait * [ ] Landscape **Device Testing**: * [ ] iPhone SE (1st Gen) * [ ] iPhone 8 * [ ] iPhone X * [ ] iPhone 14 Pro * [ ] iPad **OS Testing**: * [ ] iOS 15 * [ ] iOS 16 * [ ] iOS 17 **Theme Testing**: * [ ] Light theme * [ ] Dark theme --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Please make sure all GH checks passed before merging. It can take around 20 minutes. Briefly review this PR to see if there are no issues or red flags and then merge it.
samsymons
added a commit
that referenced
this pull request
Oct 29, 2024
# By Mariusz Śpiewak (3) and others # Via Elle Sullivan (2) and others * main: (26 commits) Release 7.143.0-0 (#3497) Fix the condition (#3496) Use cookie to share subscription access token on DDG domains (#3488) Show VPN onboarding tips (#3429) TestFlight only release and promotion (#3474) point to BSK branch (#3492) Remove Recovered References (#3457) Fix image set warning (#3459) Make running the script more explicit (#3484) Add pixel when the error page is shown (#3487) Release 7.142.0-1 (#3483) Merge Hotfix/7.141.1 into 7.142.0 release branch (#3481) Release 7.141.1-0 (#3479) Handle 'data' scheme downloads through WebKit's `decisionHandler(.download)` (#3478) Email parsing improved (#3436) Fix updating OmniBar constraints on iOS18 (#3473) For BLOB downloads make sure the file is not preview-able before triggering the download (#3472) Set UserDefaults API access reason to 1C8F.1 (#3475) Bump BSK to the version with newTabSearchField feature flag (#3449) Use New Tab Page implementation without customization features (#3453) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208593312489483/f
Tech Design URL:
CC:
Description:
Merges the hot fix into the latest release branch
Steps to test this PR:
1.
2.
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template