Add possibility to stop page loading #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaceklyp
approved these changes
Nov 13, 2024
samsymons
added a commit
that referenced
this pull request
Nov 14, 2024
# By Daniel Bernal (3) and others # Via GitHub * main: Remove the `ld_classic` build setting (#3575) text zoom improvements (#3509) Add support for local overrides for feature flags (#3571) pixels for bookmarks > favorites tab (#3572) Sync BSK with macos (#3561) Add possibility to stop page loading (#3553) [DuckPlayer] Overlay Usage Pixels (#3565) Update pr.yml Update pr.yml # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
8 tasks
dus7
added a commit
that referenced
this pull request
Nov 20, 2024
Task/Issue URL: https://app.asana.com/0/1206226850447395/1208790263070149/f Tech Design URL: CC: **Description**: Caused by #3553. Unnecessary text field clean was performed when `OmniBarState` changed the internal value of `isLoading` without changing the state kind. This caused suggestion tray controller with favorites to appear. **Steps to test this PR**: 1. Turn off automatic data clearing on app exit. 2. Add at least one favorite. 3. Open tab with some url address. 4. Relaunch the app. 5. Verify suggestions tray is not shown and favorites are not visible while the tab is loading. **Definition of Done (Internal Only)**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? **Orientation Testing**: * [ ] Portrait * [ ] Landscape **Device Testing**: * [ ] iPhone SE (1st Gen) * [ ] iPhone 8 * [ ] iPhone X * [ ] iPhone 14 Pro * [ ] iPad --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206226850447395/1206267785501484/f
Tech Design URL:
CC:
Description:
Adds an additional OmniBar state variation when the website is loading, allowing to stop the loading process.
Steps to test this PR:
💡 It's helpful to test on a physical device (with link conditioner enabled to slow down loading) or using link conditioner for simulator.
a. if no valid resources were loaded error page should be presented
b. if some resources were loaded and can be displayed, partially loaded website should be visible
c. pixel is sent.
Definition of Done (Internal Only):
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template