Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alpha build compilation #3584

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Fix alpha build compilation #3584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9045097
Use the same target name for alpha builds as all other builds.
samsymons Nov 17, 2024
201fc20
Remove main branch check.
samsymons Nov 17, 2024
f06ccdd
Override the module name for the alpha build.
samsymons Nov 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/workflows/alpha.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,6 @@ jobs:

steps:

- name: Assert main branch
run: |
case "${{ github.ref }}" in
*main) ;;
*) echo "👎 Not main branch"; exit 1 ;;
esac

- name: Register SSH keys for access to certificates
uses: webfactory/ssh-agent@v0.7.0
with:
Expand Down
1 change: 1 addition & 0 deletions DuckDuckGo.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10456,6 +10456,7 @@
"@executable_path/Frameworks",
);
PRODUCT_BUNDLE_IDENTIFIER = com.duckduckgo.mobile.ios.alpha;
PRODUCT_MODULE_NAME = DuckDuckGo;
PRODUCT_NAME = "$(TARGET_NAME)-Alpha";
"PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "match AppStore com.duckduckgo.mobile.ios.alpha";
SWIFT_ACTIVE_COMPILATION_CONDITIONS = ALPHA;
Expand Down
Loading