Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore dynamic type when changing zoom level #3638

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Ignore dynamic type when changing zoom level #3638

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions DuckDuckGo/TextZoomCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,7 @@ final class TextZoomCoordinator: TextZoomCoordinating {
private func applyTextZoom(_ webView: WKWebView) {
guard isEnabled else { return }
let level = textZoomLevel(forHost: webView.url?.host)
let dynamicTypeScalePercentage = UIFontMetrics.default.scaledValue(for: 1.0)
let viewScale = CGFloat(level.rawValue) / 100 * dynamicTypeScalePercentage
Comment on lines -113 to -114
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the original UserScript implementation, we respect dynamic type for certain known sites (only wikipedia I think). There's probably a historical reason for this.

let viewScale = CGFloat(level.rawValue) / 100
webView.applyViewScale(viewScale)
}

Expand Down
Loading