Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BSK with version including Privacy Stats module for use in the macOS browser #3651

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Nov 29, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1208246350498754/f

Description:
This change is transparent to iOS since the new code isn't used.
The bump to C-S-S contains fixes to macOS's HTML New Tab Page.

Steps to test this PR:
Verify that CI is green.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@ayoy ayoy assigned ayoy and unassigned aataraxiaa Nov 29, 2024
@ayoy ayoy merged commit 389b441 into main Nov 29, 2024
13 checks passed
@ayoy ayoy deleted the dominik/privacy-stats branch November 29, 2024 14:54
samsymons added a commit that referenced this pull request Nov 29, 2024
# By Bartek Waresiak (3) and others
# Via GitHub (1) and others
* main:
  Remove incorrect tests and reenable some of the non-flaky ones (#3653)
  Update BSK with version including Privacy Stats module for use in the macOS browser (#3651)
  point to BSK branch and updates (#3636)
  Release 7.147.0-6 (#3652)
  Revert incorrect push
  Client displays correct subscription (#3620)
  Re-enable pixel tests except for flaky one
  Remove Special Pages tests
  Include inactive tabs statistics in daily tab switcher pixel (#3643)
  Release 7.147.0-5 (#3649)
  [Release PR] Add StoreKit debugging metadata to the debug menu (#3637)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Nov 30, 2024
# By Bartek Waresiak (3) and others
# Via GitHub (1) and others
* main:
  Add support for RMF survey `locale` parameter (#3648)
  Remove incorrect tests and reenable some of the non-flaky ones (#3653)
  Update BSK with version including Privacy Stats module for use in the macOS browser (#3651)
  point to BSK branch and updates (#3636)
  Release 7.147.0-6 (#3652)
  Revert incorrect push
  Client displays correct subscription (#3620)
  Re-enable pixel tests except for flaky one
  Remove Special Pages tests
  Include inactive tabs statistics in daily tab switcher pixel (#3643)
  Release 7.147.0-5 (#3649)
  [Release PR] Add StoreKit debugging metadata to the debug menu (#3637)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants