Adjust app icons to support HomeScreen tinting on iOS 18 #3680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dus7
changed the title
dus7
changed the title
dus7
force-pushed
the
mariusz/ios18-icons-variants
branch
from
d46fa39 to
06433a2
Compare
samsymons
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
The changes as described look great to me, thanks Mariusz! I tested that each appearance on each supported version of iOS looks correct, and that the tinting on iOS 18 works as expected. The icon looks much better!
I'm worried that users won't like losing the option to choose a color when running in dark mode (I use 100% dark mode and I'll miss the purple icon), but let's see how that shakes out in the ship review. Assuming nothing changes there, this looks good.
samsymons
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206226850447395/1208303061602073/f
Tech Design URL:
CC:
Description:
Moving app icons to assets in order to support iOS 18 tinting on Home Screen. There were a few issues, which look like a bug or inconsistency in iOS:
UIImage, thus I needed additional separate images for display on UI. I tried out Apple's sample project and it also failed to display app icons.Info.plisteven though the functionality did work without them. It seems those values are included by compiler, but without having those predefined, the Alpha build app icon was used throughout Xcode UI.I removed multiple variants for each AppIcon asset and left only a single image of 1024px size. Starting from Xcode 14 asset catalog can use this size to autogenerate all other required sizes.
Steps to test this PR:
Definition of Done (Internal Only):
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template