Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Chat transition animation #3682

Merged
merged 1 commit into from
Dec 5, 2024
Merged

AI Chat transition animation #3682

merged 1 commit into from
Dec 5, 2024

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Dec 5, 2024

Task/Issue URL: https://app.asana.com/0/1204167627774280/1208906546735883/f

Description:
Add new transition for AI Chat UI

Steps to test this PR:

  1. Open AI Chat in portrait, landscape. iPad OS, iOS and check if it's working as expected

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@brindy brindy self-requested a review December 5, 2024 15:46
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work :)

@Bunn Bunn merged commit 684a4d9 into release/7.148.0 Dec 5, 2024
17 checks passed
@Bunn Bunn deleted the bunn/aichat/animation branch December 5, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants