Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smodi/compilation time tracking #3685

Merged
merged 15 commits into from
Dec 9, 2024
Merged

Conversation

studiosutara
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1208613456171888/1208801514911205/f
Tech Design URL: https://app.asana.com/0/481882893211075/1208730499188670/f
CC:

Description:

Steps to test this PR:
1.
2.

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@studiosutara studiosutara marked this pull request as ready for review December 9, 2024 17:48
…mpilation_time_tracking

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…mpilation_time_tracking

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@studiosutara studiosutara merged commit 8c0cb45 into main Dec 9, 2024
13 checks passed
@studiosutara studiosutara deleted the smodi/compilation_time_tracking branch December 9, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants