Update RMF version matching to ignore build number #3686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 6, 2024
Required: Task/Issue URL: https://app.asana.com/0/1207619243206445/1208908529122506/f iOS PR: duckduckgo/iOS#3686 macOS PR: duckduckgo/macos-browser#3635 What kind of version bump will this require?: Patch Description: This PR updates the RMF version matching logic to ignore build number. Previously, when you tried to match a version like 1.110.0, it would fail because you needed to know the build number.
…ild-number # By Alessandro Boron (1) and Sabrina Tardio (1) # Via GitHub * main: add fake experiment (#3688) Alessandro/onboarding add to dock experiment setup (#3679) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
deleted the
sam/update-rmf-version-matching-to-ignore-build-number
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207619243206445/1208908529122506/f
Tech Design URL:
CC:
Description:
This PR updates the iOS app to pull in the BSK app version matching changes added in duckduckgo/BrowserServicesKit#1118.
Steps to test this PR:
Definition of Done (Internal Only):
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template