Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malware protection (BSK macOS) #3690

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Malware protection (BSK macOS) #3690

merged 3 commits into from
Dec 10, 2024

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Dec 6, 2024

Task/Issue URL: https://app.asana.com/0/481882893211075/1208033567421351/f
BSK PR: duckduckgo/BrowserServicesKit#1099
macOS PR: duckduckgo/macos-browser#3604

Description:

  • add Malware support to malicious site detection

Steps to test this PR:

  1. Validate phishing detection / badssl.com detection works as before

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@mallexxx mallexxx merged commit 1dfa23b into main Dec 10, 2024
13 checks passed
@mallexxx mallexxx deleted the alex/malware-protection-6 branch December 10, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants