Update Overlay Pixel implementation #3701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunn
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
LGTM, got all pixels fired
Pixel fired duckplayer.youtube.overlay.navigation.back
Pixel fired duckplayer.youtube.overlay.navigation.refresh
Pixel fired duckplayer.youtube.overlay.navigation.within-youtube
Pixel fired duckplayer.youtube.overlay.navigation.outside-youtube
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204099484721401/1208910025199824/f
Tech Design URL:
CC:
Description:
Refactors Overlay Pixels to use WebKit KVO and backForward lists for improved reliability
Steps to test this PR:
duckplayer.youtube.overlay.navigation.backpixel firesduckplayer.youtube.overlay.navigation.refreshpixel firesduckplayer.youtube.overlay.navigation.within-youtubeduckplayer.youtube.overlay.navigation.outside-youtubefiresSmoke test going to/from videos and confirm pixels fire as expected.