Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fastfile to wrap lanes in a platform block #3711

Merged

Conversation

samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/0/1208949587447312/f
Tech Design URL:
CC:

Description:

This PR updates the iOS Fastfile to wrap lanes in a platform block.

This introduces zero changes to the usability of the Fastfile as it is only intended to lay the groundwork for the move to the monorepo. However, the diff is noisy since wrapping all lanes in a block caused an indentation change. Sorry!

Steps to test this PR:

  1. Test some lanes to verify that everything works as expected

Definition of Done (Internal Only):

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from ayoy December 11, 2024 02:42
Copy link

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 3aa2b0b

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works well too :)

@samsymons samsymons merged commit 8017c33 into main Dec 12, 2024
16 checks passed
@samsymons samsymons deleted the sam/update-ios-fastlane-to-wrap-lanes-in-platform-block branch December 12, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants