Skip to content

Show history menu on cmd+y shortcut #6906

Show history menu on cmd+y shortcut

Show history menu on cmd+y shortcut #6906

Triggered via pull request January 24, 2024 07:47
Status Success
Total duration 5m 18s
Artifacts

pr.yml

on: pull_request
Matrix: Test
Matrix: Make Release Build
SwiftLint
1m 5s
SwiftLint
Verify autoconsent bundle
13s
Verify autoconsent bundle
ShellCheck
6s
ShellCheck
Private API Report  /  Update PR comment
3s
Private API Report / Update PR comment
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

45 warnings and 2 notices
Make Release Build (DuckDuckGo Privacy Browser): DuckDuckGo/Sharing/SharingMenu.swift#L76
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
Make Release Build (DuckDuckGo Privacy Browser): DuckDuckGo/Sharing/SharingMenu.swift#L78
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
Make Release Build (DuckDuckGo Privacy Browser): DuckDuckGo/Preferences/Model/PrivacySecurityPreferences.swift#L33
variable 'udWrapper' was never mutated; consider changing to 'let' constant
Make Release Build (DuckDuckGo Privacy Browser): DuckDuckGo/Waitlist/Views/WaitlistViewControllerPresenter.swift#L64
variable 'waitlist' was never mutated; consider changing to 'let' constant
Make Release Build (DuckDuckGo Privacy Browser): DuckDuckGo/Sync/SyncBookmarksAdapter.swift#L47
variable 'udWrapper' was never mutated; consider changing to 'let' constant
Make Release Build (DuckDuckGo Privacy Browser): DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/Invite/NetworkProtectionInviteDialog.swift#L42
weak reference will always be nil because the referenced object is deallocated here
Make Release Build (DuckDuckGo Privacy Pro): DuckDuckGo/Sharing/SharingMenu.swift#L76
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
Make Release Build (DuckDuckGo Privacy Pro): DuckDuckGo/Sharing/SharingMenu.swift#L78
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
Make Release Build (DuckDuckGo Privacy Pro): DuckDuckGo/Tab/UserScripts/SubscriptionPagesUserScript.swift#L122
immutable value 'accessToken' was never used; consider replacing with '_' or removing it
Make Release Build (DuckDuckGo Privacy Pro): DuckDuckGo/Preferences/Model/PrivacySecurityPreferences.swift#L33
variable 'udWrapper' was never mutated; consider changing to 'let' constant
Make Release Build (DuckDuckGo Privacy Pro): DuckDuckGo/Sync/SyncBookmarksAdapter.swift#L47
variable 'udWrapper' was never mutated; consider changing to 'let' constant
Make Release Build (DuckDuckGo Privacy Pro): DuckDuckGo/Waitlist/Views/WaitlistViewControllerPresenter.swift#L64
variable 'waitlist' was never mutated; consider changing to 'let' constant
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox)
not stripping binary because it is signed: /Users/runner/work/macos-browser/macos-browser/DerivedData/SourcePackages/artifacts/grdb.swift/GRDB/GRDB.xcframework/macos-arm64_x86_64/GRDB.framework/Versions/A/GRDB (in target 'DataBrokerProtectionTests' from project 'DataBrokerProtection')
Test (Non-Sandbox): DuckDuckGo/Sync/SyncBookmarksAdapter.swift#L47
variable 'udWrapper' was never mutated; consider changing to 'let' constant
Test (Non-Sandbox): DuckDuckGo/Sharing/SharingMenu.swift#L76
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
Test (Non-Sandbox): DuckDuckGo/Sharing/SharingMenu.swift#L78
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
Test (Non-Sandbox): DuckDuckGo/Preferences/Model/PrivacySecurityPreferences.swift#L33
variable 'udWrapper' was never mutated; consider changing to 'let' constant
Test (Non-Sandbox): DuckDuckGo/Waitlist/Views/WaitlistViewControllerPresenter.swift#L64
variable 'waitlist' was never mutated; consider changing to 'let' constant
Test (Non-Sandbox): DerivedData/Build/Products/CI/OpenSSL.framework/Headers/shim.h#L12
a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
Test (Non-Sandbox): DerivedData/Build/Products/CI/OpenSSL.framework/Headers/shim.h#L17
a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
Test (Non-Sandbox)
DuckDuckGoDBPBackgroundAgent isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgent' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGoVPN isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoVPN' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGo Privacy Browser isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGo Privacy Browser' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGoNotifications isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoNotifications' from project 'DuckDuckGo')
Test (Sandbox): DuckDuckGo/Sharing/SharingMenu.swift#L76
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
Test (Sandbox): DuckDuckGo/Sharing/SharingMenu.swift#L78
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
Test (Sandbox): DuckDuckGo/Preferences/View/PreferencesSidebar.swift#L72
getter 'body' took 390ms to type-check (limit: 250ms)
Test (Sandbox): DuckDuckGo/Sync/SyncBookmarksAdapter.swift#L47
variable 'udWrapper' was never mutated; consider changing to 'let' constant
Test (Sandbox): DuckDuckGo/Common/Utilities/HardwareModel.swift#L25
'kIOMasterPortDefault' was deprecated in macOS 12.0: renamed to 'kIOMainPortDefault'
Test (Sandbox): DuckDuckGo/Sharing/SharingMenu.swift#L76
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
Test (Sandbox): DuckDuckGo/Sharing/SharingMenu.swift#L78
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
Test (Sandbox): DuckDuckGo/Common/Utilities/HardwareModel.swift#L25
'kIOMasterPortDefault' was deprecated in macOS 12.0: renamed to 'kIOMainPortDefault'
Test (Sandbox)
DuckDuckGo Privacy Browser App Store isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGo Privacy Browser App Store' from project 'DuckDuckGo')
Test (Non-Sandbox)
Tests Passed: 0 failed, 0 skipped, 189 total (13.622 seconds)
Test (Sandbox)
Tests Passed: 0 failed, 0 skipped, 9 total (0.017 seconds)