Don't report CancellationError from BookmarksFaviconsFetcher #6955
ayoypr.yml
on: pull_request
Annotations
53 warnings and 2 notices
|
ShellCheck
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Verify autoconsent bundle
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
SwiftLint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Make Release Build (DuckDuckGo Privacy Pro)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Make Release Build (DuckDuckGo Privacy Pro):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
|
Make Release Build (DuckDuckGo Privacy Pro):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
|
Make Release Build (DuckDuckGo Privacy Pro):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
|
Make Release Build (DuckDuckGo Privacy Pro):
DuckDuckGo/Sharing/SharingMenu.swift#L76
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
|
|
Make Release Build (DuckDuckGo Privacy Pro):
DuckDuckGo/Sharing/SharingMenu.swift#L78
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
|
|
|
|
Make Release Build (DuckDuckGo Privacy Pro):
DuckDuckGo/Tab/UserScripts/SubscriptionPagesUserScript.swift#L122
immutable value 'accessToken' was never used; consider replacing with '_' or removing it
|
|
Make Release Build (DuckDuckGo Privacy Pro):
DuckDuckGo/Preferences/Model/PrivacySecurityPreferences.swift#L33
variable 'udWrapper' was never mutated; consider changing to 'let' constant
|
|
Make Release Build (DuckDuckGo Privacy Pro):
DuckDuckGo/Sync/SyncBookmarksAdapter.swift#L47
variable 'udWrapper' was never mutated; consider changing to 'let' constant
|
|
Make Release Build (DuckDuckGo Privacy Pro):
DuckDuckGo/Waitlist/Views/WaitlistViewControllerPresenter.swift#L64
variable 'waitlist' was never mutated; consider changing to 'let' constant
|
|
Test (Non-Sandbox)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Test (Non-Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
|
Test (Non-Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
|
Test (Non-Sandbox)
not stripping binary because it is signed: /Users/runner/work/macos-browser/macos-browser/DerivedData/SourcePackages/artifacts/grdb.swift/GRDB/GRDB.xcframework/macos-arm64_x86_64/GRDB.framework/Versions/A/GRDB (in target 'DataBrokerProtectionTests' from project 'DataBrokerProtection')
|
|
Test (Non-Sandbox):
DuckDuckGo/Waitlist/Views/WaitlistViewControllerPresenter.swift#L64
variable 'waitlist' was never mutated; consider changing to 'let' constant
|
|
Test (Non-Sandbox):
DuckDuckGo/Preferences/Model/PrivacySecurityPreferences.swift#L33
variable 'udWrapper' was never mutated; consider changing to 'let' constant
|
|
Test (Non-Sandbox):
DuckDuckGo/Sharing/SharingMenu.swift#L76
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
|
|
Test (Non-Sandbox):
DuckDuckGo/Sharing/SharingMenu.swift#L78
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
|
|
Test (Non-Sandbox):
DuckDuckGo/Common/Extensions/NSBezierPathExtension.swift#L30
switch must be exhaustive
|
|
Test (Non-Sandbox):
DuckDuckGo/Sync/SyncBookmarksAdapter.swift#L47
variable 'udWrapper' was never mutated; consider changing to 'let' constant
|
|
Test (Non-Sandbox):
DerivedData/Build/Products/CI/OpenSSL.framework/Headers/shim.h#L12
a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
|
|
Test (Non-Sandbox)
DuckDuckGoDBPBackgroundAgent isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgent' from project 'DuckDuckGo')
|
|
Test (Non-Sandbox)
DuckDuckGoVPN isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoVPN' from project 'DuckDuckGo')
|
|
Test (Non-Sandbox)
DuckDuckGo Privacy Browser isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGo Privacy Browser' from project 'DuckDuckGo')
|
|
Test (Non-Sandbox)
DuckDuckGoNotifications isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoNotifications' from project 'DuckDuckGo')
|
|
Make Release Build (DuckDuckGo Privacy Browser)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Make Release Build (DuckDuckGo Privacy Browser):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
|
Make Release Build (DuckDuckGo Privacy Browser):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
|
Make Release Build (DuckDuckGo Privacy Browser):
DerivedData/Build/Products/Release/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
|
|
Make Release Build (DuckDuckGo Privacy Browser):
DuckDuckGo/Sharing/SharingMenu.swift#L76
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
|
|
Make Release Build (DuckDuckGo Privacy Browser):
DuckDuckGo/Sharing/SharingMenu.swift#L78
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
|
|
|
|
Make Release Build (DuckDuckGo Privacy Browser):
DuckDuckGo/Preferences/Model/PrivacySecurityPreferences.swift#L33
variable 'udWrapper' was never mutated; consider changing to 'let' constant
|
|
Make Release Build (DuckDuckGo Privacy Browser):
DuckDuckGo/Waitlist/Views/WaitlistViewControllerPresenter.swift#L64
variable 'waitlist' was never mutated; consider changing to 'let' constant
|
|
Make Release Build (DuckDuckGo Privacy Browser):
DuckDuckGo/Sync/SyncBookmarksAdapter.swift#L47
variable 'udWrapper' was never mutated; consider changing to 'let' constant
|
|
Make Release Build (DuckDuckGo Privacy Browser):
DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/Invite/NetworkProtectionInviteDialog.swift#L42
weak reference will always be nil because the referenced object is deallocated here
|
|
Test (Sandbox)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3, mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Test (Sandbox):
DuckDuckGo/Common/Utilities/HardwareModel.swift#L25
'kIOMasterPortDefault' was deprecated in macOS 12.0: renamed to 'kIOMainPortDefault'
|
|
Test (Sandbox):
DuckDuckGo/Preferences/View/PreferencesSidebar.swift#L72
getter 'body' took 329ms to type-check (limit: 250ms)
|
|
Test (Sandbox):
DuckDuckGo/Preferences/View/PreferencesSidebar.swift#L72
getter 'body' took 355ms to type-check (limit: 250ms)
|
|
Test (Sandbox):
DuckDuckGo/Preferences/Model/PrivacySecurityPreferences.swift#L33
variable 'udWrapper' was never mutated; consider changing to 'let' constant
|
|
Test (Sandbox):
DuckDuckGo/Sync/SyncBookmarksAdapter.swift#L47
variable 'udWrapper' was never mutated; consider changing to 'let' constant
|
|
Test (Sandbox):
DuckDuckGo/Sync/SyncBookmarksAdapter.swift#L47
variable 'udWrapper' was never mutated; consider changing to 'let' constant
|
|
Test (Sandbox):
DuckDuckGo/Sharing/SharingMenu.swift#L76
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
|
|
Test (Sandbox):
DuckDuckGo/Sharing/SharingMenu.swift#L78
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
|
|
Test (Sandbox):
DuckDuckGo/Common/Extensions/NSBezierPathExtension.swift#L30
switch must be exhaustive
|
|
Test (Sandbox):
DuckDuckGo/Sharing/SharingMenu.swift#L76
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
|
|
Test (Sandbox)
DuckDuckGo Privacy Browser App Store isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGo Privacy Browser App Store' from project 'DuckDuckGo')
|
|
Private API Report / Update PR comment
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: marocchino/sticky-pull-request-comment@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Test (Non-Sandbox)
Tests Passed: 0 failed, 0 skipped, 189 total (13.670 seconds)
|
|
Test (Sandbox)
Tests Passed: 0 failed, 0 skipped, 9 total (0.016 seconds)
|