Skip to content

Commit

Permalink
Address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jotaemepereira committed Dec 21, 2023
1 parent cda7456 commit 49fd1bd
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ final class DataBrokerProtectionSubscriptionEventHandler {

@objc private func handleAccountDidSignIn() {
guard let token = accountManager.token else {
Pixel.fire(.dataBrokerProtectionSubscriptionErrorWhenFetchingToken)
Pixel.fire(.dataBrokerProtectionErrorWhenFetchingSubscriptionAuthTokenAfterSignIn)
assertionFailure("[DBP Subscription] AccountManager signed in but token could not be retrieved")
return
}
Expand Down
6 changes: 3 additions & 3 deletions DuckDuckGo/Statistics/PixelEvent.swift
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ extension Pixel {
case dataBrokerProtectionWaitlistTermsAndConditionsAccepted

// DataBrokerProtection Other
case dataBrokerProtectionSubscriptionErrorWhenFetchingToken
case dataBrokerProtectionErrorWhenFetchingSubscriptionAuthTokenAfterSignIn

// 28-day Home Button
case homeButtonHidden
Expand Down Expand Up @@ -542,8 +542,8 @@ extension Pixel.Event {
return "m_mac_dbp_imp_terms"
case .dataBrokerProtectionWaitlistTermsAndConditionsAccepted:
return "m_mac_dbp_ev_terms_accepted"
case .dataBrokerProtectionSubscriptionErrorWhenFetchingToken:
return "m_mac_dbp_subscription_error_when_fetching_token"
case .dataBrokerProtectionErrorWhenFetchingSubscriptionAuthTokenAfterSignIn:
return "m_mac_dbp_error_when_fetching_subscription_auth_token_after_sign_in"

// 28-day Home Button
case .homeButtonHidden:
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo/Statistics/PixelParameters.swift
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ extension Pixel.Event {
.dataBrokerProtectionWaitlistCardUITapped,
.dataBrokerProtectionWaitlistTermsAndConditionsDisplayed,
.dataBrokerProtectionWaitlistTermsAndConditionsAccepted,
.dataBrokerProtectionSubscriptionErrorWhenFetchingToken,
.dataBrokerProtectionErrorWhenFetchingSubscriptionAuthTokenAfterSignIn,
.homeButtonLeft,
.homeButtonRight,
.homeButtonHidden:
Expand Down

0 comments on commit 49fd1bd

Please sign in to comment.