Skip to content

Commit

Permalink
Merge branch 'main' into graeme/geoswitching
Browse files Browse the repository at this point in the history
* main: (48 commits)
  Add additional VPN startup pixels (#1975)
  Updates to Autofill Logins copy (#1924)
  Bump version to 1.69.0 (95)
  Remove the reconnect/disconnect logic from the connection tester (#1970)
  Set marketing version to 1.69.0
  Update embedded files
  DBP: Send internal user param for dbp waitlist pixels (#1972)
  Move release task to proper section in Code Freeze workflow (#1977)
  drop Main.storyboard (#1944)
  Add GHA workflow to cut release branch (#1976)
  Move DBP tests into main target (#1974)
  Use static date for PixelKit tests (#1973)
  Remove DBP test target (#1961)
  Fix date generator for time machine (#1969)
  Improve sync set up error handling (#1966)
  remove QR code from save recovery PDF view (#1968)
  change order of items in autofill add new item (#1967)
  Fix PR Checks workflow (#1962)
  Bump version to 1.68.0 (93)
  Update embedded files
  ...
  • Loading branch information
samsymons committed Dec 15, 2023
2 parents 864bcf9 + 91324f4 commit 7904960
Show file tree
Hide file tree
Showing 167 changed files with 2,236 additions and 2,299 deletions.
23 changes: 13 additions & 10 deletions .github/workflows/build_appstore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,13 @@ on:
description: "Asana release task URL"
required: true
type: string
branch:
description: "Branch name"
required: false
type: string
secrets:
SSH_PRIVATE_KEY_FASTLANE_MATCH:
required: true
SSH_PRIVATE_KEY_FIND_IN_PAGE:
required: true
APPLE_API_KEY_BASE64:
required: true
APPLE_API_KEY_ID:
Expand All @@ -51,7 +53,7 @@ jobs:

name: Make App Store Connect Release

runs-on: macos-13
runs-on: macos-13-xlarge

env:
destination: ${{ github.event.inputs.destination || inputs.destination }}
Expand All @@ -62,9 +64,9 @@ jobs:
- name: Assert release branch
if: env.destination == 'appstore'
run: |
case "${{ github.ref }}" in
refs/heads/release/*) ;;
refs/heads/hotfix/*) ;;
case "${{ inputs.branch || github.ref_name }}" in
release/*) ;;
hotfix/*) ;;
*) echo "👎 Not a release or hotfix branch"; exit 1 ;;
esac
Expand All @@ -73,12 +75,12 @@ jobs:
with:
ssh-private-key: |
${{ secrets.SSH_PRIVATE_KEY_FASTLANE_MATCH }}
${{ secrets.SSH_PRIVATE_KEY_FIND_IN_PAGE }}
- name: Check out the code
uses: actions/checkout@v3
with:
submodules: recursive
ref: ${{ inputs.branch || github.ref_name }}

- name: Select Xcode
run: sudo xcode-select -s /Applications/Xcode_$(<.xcode-version).app/Contents/Developer
Expand All @@ -100,12 +102,13 @@ jobs:
bundle exec fastlane release_${{ env.destination }}
dsyms_path="${{ github.workspace }}/DuckDuckGo-AppStore.app.dSYM.zip"
mv -f "${{ github.workspace }}/DuckDuckGo App Store.app.dSYM.zip" "${dsyms_path}"
app_version="$(cut -d ' ' -f 3 < Configuration/Version.xcconfig)"
version="$(cut -d ' ' -f 3 < Configuration/Version.xcconfig)"
build_number="$(cut -d ' ' -f 3 < Configuration/BuildNumber.xcconfig)"
echo "dsyms_path=${dsyms_path}" >> $GITHUB_ENV
echo "app_version=${app_version}" >> $GITHUB_ENV
echo "app_version=${version}.${build_number}" >> $GITHUB_ENV
- name: Upload dSYMs artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: DuckDuckGo-${{ env.destination }}-dSYM-${{ env.app_version }}
path: ${{ env.dsyms_path }}
Expand Down
22 changes: 10 additions & 12 deletions .github/workflows/build_notarized.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ on:
description: "Asana release task URL"
required: true
type: string
branch:
description: "Branch name"
required: false
type: string
secrets:
BUILD_CERTIFICATE_BASE64:
required: true
Expand Down Expand Up @@ -65,8 +69,6 @@ on:
required: true
NETP_NOTIFICATIONS_REVIEW_PROVISION_PROFILE_BASE64:
required: true
SSH_PRIVATE_KEY_FIND_IN_PAGE:
required: true
APPLE_API_KEY_BASE64:
required: true
APPLE_API_KEY_ID:
Expand All @@ -89,7 +91,7 @@ jobs:

name: Export Notarized App

runs-on: macos-13
runs-on: macos-13-xlarge

outputs:
app-version: ${{ steps.set-outputs.outputs.app-version }}
Expand All @@ -101,15 +103,11 @@ jobs:

steps:

- name: Register SSH keys for submodules access
uses: webfactory/ssh-agent@v0.7.0
with:
ssh-private-key: ${{ secrets.SSH_PRIVATE_KEY_FIND_IN_PAGE }}

- name: Check out the code
uses: actions/checkout@v3
with:
submodules: recursive
ref: ${{ inputs.branch || github.ref_name }}

- name: Install Apple Developer ID Application certificate
uses: ./.github/actions/install-certs-and-profiles
Expand Down Expand Up @@ -161,13 +159,13 @@ jobs:
echo "app-name=${{ env.app-name }}" >> $GITHUB_OUTPUT
- name: Upload app artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: DuckDuckGo-${{ env.release-type }}-${{ env.app-version }}.app
path: ${{ github.workspace }}/release/DuckDuckGo-${{ env.app-version }}.zip

- name: Upload dSYMs artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: DuckDuckGo-${{ env.release-type }}-dSYM-${{ env.app-version }}
path: ${{ github.workspace }}/release/DuckDuckGo-${{ env.app-version }}-dSYM.zip
Expand Down Expand Up @@ -211,7 +209,7 @@ jobs:
steps:

- name: Fetch app bundle
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: DuckDuckGo-${{ env.release-type }}-${{ env.app-version }}.app
path: ${{ github.workspace }}/dmg
Expand Down Expand Up @@ -240,7 +238,7 @@ jobs:
"dmg"
- name: Upload DMG artifact
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: DuckDuckGo-${{ env.release-type }}-${{ env.app-version }}.dmg
path: ${{ github.workspace }}/duckduckgo*-${{ env.app-version }}.dmg
Expand Down
120 changes: 120 additions & 0 deletions .github/workflows/bump_internal_release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,120 @@
name: Bump Internal Release

on:
workflow_dispatch:
inputs:
asana-task-url:
description: "Asana release task URL"
required: true
type: string

jobs:

update_embedded_files:

name: Update Embedded Files

runs-on: macos-13-xlarge
timeout-minutes: 10

steps:

- name: Assert release branch
run: |
case "${{ github.ref }}" in
refs/heads/release/*) ;;
*) echo "👎 Not a release branch"; exit 1 ;;
esac
- name: Check out the code
uses: actions/checkout@v3
with:
submodules: recursive

- name: Select Xcode
run: sudo xcode-select -s /Applications/Xcode_$(<.xcode-version).app/Contents/Developer

- name: Prepare fastlane
run: bundle install

- name: Update embedded files
env:
APPLE_API_KEY_BASE64: ${{ secrets.APPLE_API_KEY_BASE64 }}
APPLE_API_KEY_ID: ${{ secrets.APPLE_API_KEY_ID }}
APPLE_API_KEY_ISSUER: ${{ secrets.APPLE_API_KEY_ISSUER }}
run: |
git config --global user.name "Dax the Duck"
git config --global user.email "dax@duckduckgo.com"
bundle exec fastlane update_embedded_files
run_tests:

name: Run Tests

needs: update_embedded_files
uses: ./.github/workflows/pr.yml
secrets:
ASANA_ACCESS_TOKEN: ${{ secrets.ASANA_ACCESS_TOKEN }}

increment_build_number:

name: Increment Build Number

needs: run_tests
runs-on: macos-13-xlarge
timeout-minutes: 10

steps:

- name: Check out the code
uses: actions/checkout@v3
with:
submodules: recursive
ref: ${{ github.ref_name }}

- name: Select Xcode
run: sudo xcode-select -s /Applications/Xcode_$(<.xcode-version).app/Contents/Developer

- name: Prepare fastlane
run: bundle install

- name: Increment build number
env:
APPLE_API_KEY_BASE64: ${{ secrets.APPLE_API_KEY_BASE64 }}
APPLE_API_KEY_ID: ${{ secrets.APPLE_API_KEY_ID }}
APPLE_API_KEY_ISSUER: ${{ secrets.APPLE_API_KEY_ISSUER }}
run: |
git config --global user.name "Dax the Duck"
git config --global user.email "dax@duckduckgo.com"
bundle exec fastlane bump_internal_release update_embedded_files:false
prepare_release:
name: Prepare Release
needs: increment_build_number
uses: ./.github/workflows/release.yml
with:
asana-task-url: ${{ github.event.inputs.asana-task-url }}
secrets:
BUILD_CERTIFICATE_BASE64: ${{ secrets.BUILD_CERTIFICATE_BASE64 }}
P12_PASSWORD: ${{ secrets.P12_PASSWORD }}
KEYCHAIN_PASSWORD: ${{ secrets.KEYCHAIN_PASSWORD }}
REVIEW_PROVISION_PROFILE_BASE64: ${{ secrets.REVIEW_PROVISION_PROFILE_BASE64 }}
RELEASE_PROVISION_PROFILE_BASE64: ${{ secrets.RELEASE_PROVISION_PROFILE_BASE64 }}
DBP_AGENT_RELEASE_PROVISION_PROFILE_BASE64: ${{ secrets.DBP_AGENT_RELEASE_PROVISION_PROFILE_BASE64 }}
DBP_AGENT_REVIEW_PROVISION_PROFILE_BASE64: ${{ secrets.DBP_AGENT_REVIEW_PROVISION_PROFILE_BASE64 }}
NETP_SYSEX_RELEASE_PROVISION_PROFILE_BASE64_V2: ${{ secrets.NETP_SYSEX_RELEASE_PROVISION_PROFILE_BASE64_V2 }}
NETP_SYSEX_REVIEW_PROVISION_PROFILE_BASE64_V2: ${{ secrets.NETP_SYSEX_REVIEW_PROVISION_PROFILE_BASE64_V2 }}
NETP_AGENT_RELEASE_PROVISION_PROFILE_BASE64_V2: ${{ secrets.NETP_AGENT_RELEASE_PROVISION_PROFILE_BASE64_V2 }}
NETP_AGENT_REVIEW_PROVISION_PROFILE_BASE64_V2: ${{ secrets.NETP_AGENT_REVIEW_PROVISION_PROFILE_BASE64_V2 }}
NETP_NOTIFICATIONS_RELEASE_PROVISION_PROFILE_BASE64: ${{ secrets.NETP_NOTIFICATIONS_RELEASE_PROVISION_PROFILE_BASE64 }}
NETP_NOTIFICATIONS_REVIEW_PROVISION_PROFILE_BASE64: ${{ secrets.NETP_NOTIFICATIONS_REVIEW_PROVISION_PROFILE_BASE64 }}
APPLE_API_KEY_BASE64: ${{ secrets.APPLE_API_KEY_BASE64 }}
APPLE_API_KEY_ID: ${{ secrets.APPLE_API_KEY_ID }}
APPLE_API_KEY_ISSUER: ${{ secrets.APPLE_API_KEY_ISSUER }}
ASANA_ACCESS_TOKEN: ${{ secrets.ASANA_ACCESS_TOKEN }}
MM_HANDLES_BASE64: ${{ secrets.MM_HANDLES_BASE64 }}
MM_WEBHOOK_URL: ${{ secrets.MM_WEBHOOK_URL }}
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
SSH_PRIVATE_KEY_FASTLANE_MATCH: ${{ secrets.SSH_PRIVATE_KEY_FASTLANE_MATCH }}
Loading

0 comments on commit 7904960

Please sign in to comment.