Avoid the default empty state appearing at unexpected times.

duckduckgo · Feb 21, 2022 · ecd6d68 · ecd6d68
1 parent 610583e
commit ecd6d68
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/DuckDuckGo/SecureVault/Model/PasswordManagementItemListModel.swift b/DuckDuckGo/SecureVault/Model/PasswordManagementItemListModel.swift
@@ -359,6 +359,16 @@ final class PasswordManagementItemListModel: ObservableObject {
             selected(item: nil)
         }
     }
+
+    func clear() {
+        update(items: [])
+        filter = ""
+        clearSelection()
+
+        // Setting items to an empty array will typically show the No Data empty state, but this call is used when
+        // the popover is closed so instead there should be no empty state.
+        emptyState = .none
+    }
 
     func clearSelection() {
         selected = nil

diff --git a/DuckDuckGo/SecureVault/View/PasswordManagementViewController.swift b/DuckDuckGo/SecureVault/View/PasswordManagementViewController.swift
@@ -163,9 +163,7 @@ final class PasswordManagementViewController: NSViewController {
     }
 
     func clear() {
-        self.listModel?.update(items: [])
-        self.listModel?.filter = ""
-        self.listModel?.clearSelection()
+        self.listModel?.clear()
         self.itemModel?.clearSecureVaultModel()
     }