Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swiftlint build plugin #1318

Merged
merged 26 commits into from
Dec 18, 2023
Merged

swiftlint build plugin #1318

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6127943
swiftlint plugin in bsk
mallexxx Jun 30, 2023
28b4de5
Merge remote-tracking branch 'origin/develop' into alex/swiftlint-plugin
mallexxx Dec 6, 2023
46c7e7d
upd BSK
mallexxx Dec 6, 2023
c97e618
rollback Package.resolved
mallexxx Dec 6, 2023
44be67b
rm DuckDuckGo.xcodeproj/xcshareddata/xcschemes/DuckDuckGoAgent.xcscheme
mallexxx Dec 6, 2023
c6d848f
rollback UnitTests/DeviceAuthentication/DeviceAuthenticatorTests.swift
mallexxx Dec 6, 2023
c056c42
set swiftlint version to 0.54.0
mallexxx Dec 6, 2023
df95952
disable nesting rule
mallexxx Dec 6, 2023
c045884
add SwiftLintPlugin to Local Packages
mallexxx Dec 6, 2023
e2300a9
fix linter issue
mallexxx Dec 6, 2023
f9ff5ef
update rules
mallexxx Dec 6, 2023
5aaa848
Merge remote-tracking branch 'origin/develop' into alex/swiftlint-plugin
mallexxx Dec 6, 2023
6defa8d
bump bsk; add targets to lint
mallexxx Dec 6, 2023
3d6d28d
bump BSK; add DEBUG build condition for local packages built in DEBUG
mallexxx Dec 7, 2023
b6d70b5
Merge branch 'main' into alex/swiftlint-plugin
mallexxx Dec 7, 2023
5afadaa
Package.resolved
mallexxx Dec 7, 2023
652b9c1
fix file headers; allow zero lintable files
mallexxx Dec 7, 2023
e9ac5c5
move .swiftlint.tests.yml to tests folder as per-folder .swiftlint.yml
mallexxx Dec 7, 2023
858ea60
fix linter issues
mallexxx Dec 7, 2023
ebc8ad8
Merge remote-tracking branch 'origin/main' into alex/swiftlint-plugin
mallexxx Dec 18, 2023
edfbdf2
set BSK to 94.0.3
mallexxx Dec 18, 2023
8518443
Merge remote-tracking branch 'origin/main' into alex/swiftlint-plugin
mallexxx Dec 18, 2023
52703f3
fix tests linter issues
mallexxx Dec 18, 2023
65aeefd
fix linter issue
mallexxx Dec 18, 2023
0163c6f
fix ci checks
mallexxx Dec 18, 2023
fabd2ac
rollback unintended pbxproj change
mallexxx Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- name: SwiftLint
uses: docker://norionomura/swiftlint:0.53.0
uses: docker://norionomura/swiftlint:0.54.0
with:
args: swiftlint --reporter github-actions-logging --strict

Expand Down
53 changes: 0 additions & 53 deletions .swiftlint.tests.yml
View file
Open in desktop

This file was deleted.

12 changes: 6 additions & 6 deletions .swiftlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
allow_zero_lintable_files: true

disabled_rules:
- no_space_in_method_call
- multiple_closures_with_trailing_closure
Expand All @@ -9,9 +11,12 @@ disabled_rules:
- implicit_getter
- function_parameter_count
- trailing_comma
- nesting
- opening_brace

opt_in_rules:
- file_header
- explicit_init

custom_rules:
explicit_non_final_class:
Expand Down Expand Up @@ -41,15 +46,13 @@ file_length:
type_body_length:
warning: 500
error: 500
nesting:
type_level: 2
large_tuple:
warning: 4
error: 5
file_header:
required_pattern: |
\/\/
\/\/ .*?\.swift
\/\/ SWIFTLINT_CURRENT_FILENAME
Comment on lines -52 to +55
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

\/\/
\/\/ Copyright © \d{4} DuckDuckGo\. All rights reserved\.
\/\/
Expand All @@ -69,10 +72,7 @@ file_header:
# General Config
excluded:
- DuckDuckGo/Common/Localizables/UserText.swift
- UnitTests
- IntegrationTests
- LocalPackages/*/Package.swift
- release
- UITests
- vendor
- DerivedData
Loading