Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofill "Never Save for this Site" support for iOS #1827

Merged
merged 11 commits into from
Nov 16, 2023

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Nov 9, 2023

Task/Issue URL: https://app.asana.com/0/0/1205783642285427/f
Tech Design URL:
CC:

Description:
BSK update to support "Never Save for this Site" on iOS including support for getRuntimeConfiguration

Steps to test this PR:

  1. Smoke test Autofill confirming everything still works as before

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

…r-prompt-save-ios

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…r-prompt-save-ios

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@afterxleep afterxleep self-requested a review November 13, 2023 13:51
Copy link
Contributor

@afterxleep afterxleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autofill saving, generating and updating seems fine to me. One thing although likely unrelated is that the in-context signup for private email protection does not seem to be working in my case. (Tested in the release version and it seems fine)

Screen Recording 2023-11-13 at 2 50 02 PM

…r-prompt-save-ios

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
amddg44 added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Nov 16, 2023
Task/Issue URL: https://app.asana.com/0/0/1205783642285427/f
iOS PR: duckduckgo/iOS#2104
macOS PR: duckduckgo/macos-browser#1827
What kind of version bump will this require?: Minor

Description:
Adds Autofill "Never Save for this Site" support for iOS
@amddg44 amddg44 merged commit 70fbdec into develop Nov 16, 2023
16 checks passed
@amddg44 amddg44 deleted the anya/autofill-never-prompt-save-ios branch November 16, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants