Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid waitlist invite code redemption after waitlist end #2347

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Avoid waitlist invite code redemption after waitlist end #2347

merged 1 commit into from
Mar 7, 2024

Conversation

samsymons
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1199230911884351/1206789264380517/f
Tech Design URL:
CC:

Description:

This PR fixes an issue where the waitlist invite code was being re-redeemed after the waitlist ends.

The fix is to check the privacy config when re-redeeming.

Steps to test this PR:

  1. Search for the line quackdev and change it to quack so that you join the prod waitlist
  2. Reset your debug build state and join the waitlist, then ask Sam to advance it
  3. After you get let in, check that you have an auth token in the keychain
  4. Delete the auth token
  5. Re-focus the app and wait a second, then check the keychain and you should see the auth token has come back again
  6. Now change the let waitlistBetaActive = configManager... line in this diff to always be false
  7. Delete the auth token in the keychain again, and refocus the app
  8. Check that no new auth token appears
Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@samsymons samsymons requested a review from diegoreymendez March 7, 2024 20:27
@samsymons samsymons merged commit 939ebf2 into release/1.78.0 Mar 7, 2024
17 checks passed
@samsymons samsymons deleted the sam/fix-token-redemption-after-waitlist-end branch March 7, 2024 21:20
@samsymons samsymons mentioned this pull request Mar 7, 2024
Merged
3 tasks
samsymons added a commit to duckduckgo/iOS that referenced this pull request Mar 7, 2024
@samsymons
Prevent redeeming invite codes after the VPN test ends (#2559)
6f79d96 
Task/Issue URL: https://app.asana.com/0/414235014887631/1206789264380520/f
Tech Design URL:
CC:

Description:

This is the iOS equivalent of duckduckgo/macos-browser#2347.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegoreymendez diegoreymendez diegoreymendez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @diegoreymendez