Duck player support on RMF on iOS - BSK #3025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunn
changed the title
afterxleep
approved these changes
Jul 26, 2024
ayoy
reviewed
Jul 26, 2024
| @@ -158,6 +158,7 @@ extension YoutubeOverlayUserScript { | |||
| PixelKit.fire(GeneralPixel.watchInDuckPlayerInitial, frequency: .legacyInitial) | |||
| } | |||
| case "play.use.thumbnail": | |||
| duckPlayerPreferences.youtubeOverlayAnyButtonPressed = true | |||
There was a problem hiding this comment.
@Bunn I’m not entirely sure if we should add this line. This case is about clicking a thumbnail, and the property we’re setting here is called “overlay any button pressed”. I suppose that initial implementation was such that this property would be set only when interacting with the main overlay, not the thumbnail.
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # LocalPackages/DataBrokerProtection/Package.swift # LocalPackages/NetworkProtectionMac/Package.swift # LocalPackages/SubscriptionUI/Package.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207870946005472/f
Description:
Steps to test this PR:
youtubeOverlayAnyButtonPressedwhen Duck Player is started via the thumbnail overlay that was missing