Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky print test in CI #3056

Closed
wants to merge 1 commit into from
Closed

Conversation

samsymons
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1199230911884351/1207944978627752/f
Tech Design URL:
CC:

Description:

This PR adds a disableInCI function that is available from unit and integration test suites. It checks for the CI environment and calls XCTSkip if the environment condition is met.

This is a draft PR as I'd like to add a comment for the disabled test, as well as check that there isn't already a better place to put the disable function. Also, I've added a hardcoded failure into the print function to check for sure that the skip is working.

Steps to test this PR:

  1. Check that CI passes

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@samsymons samsymons force-pushed the sam/disable-flaky-print-test branch from 52d5ea4 to 6c1d385 Compare August 1, 2024 00:02
@samsymons samsymons closed this Aug 1, 2024
@samsymons
Copy link
Collaborator Author

Closing this as a better fix for this flaky test was found in #3060.

@samsymons samsymons deleted the sam/disable-flaky-print-test branch August 1, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant