Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle contingency settings state on remote config #3070

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented Aug 5, 2024

Task/Issue URL: https://app.asana.com/0/0/1207976963085129/f
Tech Design URL:
CC:

Description:
Display DuckPlayer contingency message and disable settings if necessary

Steps to test this PR:

  1. Use https://jsonblob.com/api/1269938997861146624 config URL (URL set, Feature ON)
  2. Check if DuckPlayer works (it should), and that the contingency message is not shown
  3. Check that Duck Player settings is not disabled

  1. Use https://jsonblob.com/api/1269944115209822208 config URL (URL set, Feature OFF)
  2. Check if DuckPlayer works (it shouldn't) and that the contingency message is shown
  3. Click on Learn More, check that this link opens
  4. Check that Duck Player settings is disabled

  1. Use https://jsonblob.com/api/1269953336848539648 config URL (URL not set, Feature OFF)
  2. Check if DuckPlayer works (it shouldn't) and that the contingency message is not shown.

Copy link
Contributor

@afterxleep afterxleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is what I see

Screenshot 2024-08-06 at 3 01 40 PM

Bunn added 2 commits August 6, 2024 16:44
# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
#	LocalPackages/DataBrokerProtection/Package.swift
#	LocalPackages/NetworkProtectionMac/Package.swift
#	LocalPackages/SubscriptionUI/Package.swift
@Bunn Bunn merged commit f0727fc into main Aug 6, 2024
18 checks passed
@Bunn Bunn deleted the bunn/duckplayer/handle-settings branch August 6, 2024 16:18
@Bunn Bunn mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants