Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest privacy dashboard #308

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

alistairjcbrown
Copy link
Member

Task/Issue URL:
Tech Design URL:
CC: @tomasstrba @mallexxx @samsymons

Description:
Updates Privacy Dashboard with some small fixes from product review.

Steps to test this PR:
General copy changes (see PRs linked above for details)

Bugfix on blocked company count

  1. Go to https://uk.yahoo.com/
  2. The number of companies blocked in the tracker summary should be correct (ignoring first party company in the count)

Company icons and trackers sorted by prevalence

  1. Go to https://www.theguardian.com
  2. The company icons should be sorted by prevalence (Google, then Fastly)
  3. Click into the tracker details -- the track groups should be sorted by company prevalence (Google, then Fastly even though Fastly has more trackers on the page)

View updates on protection toggles

  1. Go to https://cheese.com
  2. Toggle off protections -- previously there was a flash as the popover webview refreshed, this is now gone with popover state update correctly and views re-rendering

Testing checklist:

  • Test with Release configuration

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM

@alistairjcbrown
Copy link
Member Author

@sammacbeth @tomasstrba Just a wee bump of the Privacy Dashboard to bring in changes from the product review

Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 🎖️ 🥇

@tomasstrba tomasstrba self-assigned this Nov 5, 2021
@alistairjcbrown alistairjcbrown merged commit 41c525c into develop Nov 7, 2021
@alistairjcbrown alistairjcbrown deleted the abrown/update-privacy-dashboard branch November 7, 2021 15:52
samsymons added a commit that referenced this pull request Nov 8, 2021
# By Alistair Brown (3) and others
# Via GitHub
* develop:
  Optimization of the Fire Button (#302)
  Check URL can be upgraded for user entered URLs (#298)
  Show red shield when protections disabled or on tracker network (#300)
  Use latest privacy dashboard (#308)
  Move to using mutation observing to reduce page overhead (#304)
  Unnecessary space removed (#307)
  Fire button popover UI issues (#297)

# Conflicts:
#	DuckDuckGo/NavigationBar/View/AddressBarButtonsViewController.swift
samsymons added a commit that referenced this pull request Nov 15, 2021
* develop:
  Fix Logins Popover detaching and endless Alert loop when cancelling dirty Editing mode (#317)
  Set the TrackerRadarKit version to 1.0.3 exactly (#320)
  Geolocation fix (#314)
  Fix URL Preview showing empty box (#315)
  Xcode 13 compatibility and test fixes (#313)
  Version 0.17.4
  Remove unused TrackingProtectionStats dead code (#311)
  Optimization of the Fire Button (#302)
  Check URL can be upgraded for user entered URLs (#298)
  Show red shield when protections disabled or on tracker network (#300)
  Use latest privacy dashboard (#308)
  Move to using mutation observing to reduce page overhead (#304)
  Unnecessary space removed (#307)
  Fire button popover UI issues (#297)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants