Freemium PIR: Add FreemiumPIRFeature Type and Add New State Property #3160
+440
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ike feature availability etc.
…entUser` value when providing value to RMF.
miasma13
reviewed
Aug 27, 2024
miasma13
reviewed
Aug 27, 2024
miasma13
reviewed
Aug 27, 2024
miasma13
reviewed
Aug 27, 2024
|
Updated @miasma13. |
miasma13
reviewed
Aug 28, 2024
LocalPackages/Freemium/Tests/FreemiumTests/Mocks/MockAccountManager.swift
Outdated
Show resolved
Hide resolved
|
Updated based on PR feedback and MM discussion @miasma13 . Thanks for being so thorough, it’s awesome! 👍🏼 |
miasma13
approved these changes
Aug 28, 2024
aataraxiaa
added a commit
that referenced
this pull request
Sep 10, 2024
…3160) Task/Issue URL: https://app.asana.com/0/0/1208098668401283/f **Description**: This PR targets a feature branch, and is just the first part of a larger piece of work. This PR adds:
aataraxiaa
added a commit
that referenced
this pull request
Sep 18, 2024
…3160) Task/Issue URL: https://app.asana.com/0/0/1208098668401283/f **Description**: This PR targets a feature branch, and is just the first part of a larger piece of work. This PR adds:
aataraxiaa
added a commit
that referenced
this pull request
Oct 8, 2024
…3160) Task/Issue URL: https://app.asana.com/0/0/1208098668401283/f **Description**: This PR targets a feature branch, and is just the first part of a larger piece of work. This PR adds:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208098668401283/f
Description: This PR targets a feature branch, and is just the first part of a larger piece of work. This PR adds:
FreemiumPIRFeaturetype, which is used to determine if Freemium PIR is availableisCurrentUsertoFreemiumPIRStateindicating the user is a current freemium PIR userSteps to test this PR:
Definition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation