Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freemium PIR: Rename all PIR references to DBP #3249

Conversation

aataraxiaa
Copy link
Contributor

@aataraxiaa aataraxiaa commented Sep 11, 2024

Task/Issue URL: https://app.asana.com/0/1206488453854252/1208220883876723/f

Description: No functional changes. Just renaming all PIR references for DBP (via find and replace for the different variations, e.g. pir, PIR)

Note: Also includes a minor fix to a issue compilation issue introduced in a rebase/merge.

Steps to test this PR:

  1. CI being green is good

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

github-actions bot commented Sep 11, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 2de7679

Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this!
Sorry I didn't think of it sooner

@aataraxiaa aataraxiaa merged commit 6ff98f8 into pete/feature/pir-freemium Sep 11, 2024
21 of 22 checks passed
@aataraxiaa aataraxiaa deleted the pete/feature/pir-freemium-rename-pir-to-dbp branch September 11, 2024 14:47
aataraxiaa added a commit that referenced this pull request Sep 18, 2024
Task/Issue URL:
https://app.asana.com/0/1206488453854252/1208220883876723/f

**Description**: No functional changes. Just renaming all PIR references
for DBP (via find and replace for the different variations, e.g. `pir`,
`PIR`)
aataraxiaa added a commit that referenced this pull request Oct 8, 2024
Task/Issue URL:
https://app.asana.com/0/1206488453854252/1208220883876723/f

**Description**: No functional changes. Just renaming all PIR references
for DBP (via find and replace for the different variations, e.g. `pir`,
`PIR`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants