Trigger add-task-to-project when PR marked ready for review #3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dus7
requested changes
Sep 17, 2024
There was a problem hiding this comment.
Add Task to the App Board Project step is cancelled on the ready_for_review transition. I think the line causing that is
Here it's verified the workflow was initiated by PR open event, to not spam the board when task link was edited. I think adding an event condition in this line should be enough, like so:
(github.event.action == 'opened' || github.event.action == 'ready_for_review') && (...)
Tested in #3279.
This was referenced Sep 20, 2024
dus7
approved these changes
Sep 20, 2024
dus7
added a commit
to duckduckgo/iOS
that referenced
this pull request
Sep 24, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1207931637636063/f Tech Design URL: CC: **Description**: Trigger add-task-to-project when PR marked ready for review. Counterpart of duckduckgo/macos-browser#3273. **Steps to test this PR**: * Create a copy of this branch and open a draft PR. * Mark as ready for review and check if the "Add Task to App Board Project" action is successful. **Definition of Done (Internal Only)**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1208036161861763/1207931637636063/f
Description
Trigger add-task-to-project when PR marked ready for review
Testing
You can reproduce these steps by creating a copy of this branch and opening a PR to see the CI behavior.
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation