Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freemium DBP: Copy Updates #3303

Merged

Conversation

aataraxiaa
Copy link
Contributor

@aataraxiaa aataraxiaa commented Sep 18, 2024

Task/Issue URL: https://app.asana.com/0/1206488453854252/1208161235633546/f

Description: This PR updates the copy of Freemium DBP UI to match the (nearly) final design copy.

Testing Prerequisites:

  1. Make sure you are an internal user
  2. Disable/Signout of Privacy Pro (Settings menu -> PP -> Remove from this device)
  3. Set experiment cohort (Debug Menu -> Freemium -> Set Experiment Cohort to Treatment)

Steps to test this PR:

Test 1 - New Tab Page Copy

  1. Launch browser
  2. Ensure you see a Freemium ‘promotion’ banner on the new tab page
  3. Ensure the copy in the banner matches this Figma

Test 2 - Meatball menu Copy

  1. Continuing from above
  2. Open the more options ‘meatball’ menu
  3. Ensure the copy in the banner matches this Figma

Test 3 - Post Scan Banner With Results Copy

  1. Continuing from above
  2. Click the ‘Free Scan’ button on the new tab banner
  3. It will open DBP
  4. Click Debug menu -> Freemium -> Set Results and Trigger Post-Scan Banner
  5. Open a new tab
  6. Ensure the copy in the banner matches this Figma

Test 4 - Post Scan Banner With NO Results Copy

  1. Click Debug menu -> Freemium -> Set No Results and Trigger Post-Scan Banner
  2. Open a new tab
  3. Ensure the copy in the banner matches this Figma

Test 5 - Post Scan Notification Copy

  1. Open DataBrokerProtectionAgentManager and add self.userNotificationService.sendFirstScanCompletedNotification() at line 256
  2. Open Freemium DBP via the more options ‘meatball’ menu
  3. Enter a profile and start a scan
  4. You should receive a system notification in the top right of your screen
  5. Ensure the copy in the notification matches this Figma

Test 6 - Subscriber Post Scan Notification Copy

  1. Continuing from above
  2. Sign in to your PP subscription
  3. Enter a profile and start a scan
  4. You should receive a system notification in the top right of your screen
  5. Ensure the copy in the notification matches the existing DBP notification, see screenshot below
Screenshot 2024-09-19 at 12 07 57

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@aataraxiaa aataraxiaa changed the title Pete/feature/pir freemium copy updates Freemium DBP: Copy Updates Sep 19, 2024
@aataraxiaa aataraxiaa marked this pull request as ready for review September 19, 2024 11:33
@aataraxiaa aataraxiaa requested a review from amddg44 September 19, 2024 11:34
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

DuckDuckGo/Common/Localizables/UserText.swift Outdated Show resolved Hide resolved
@aataraxiaa aataraxiaa merged commit 7942306 into pete/feature/pir-freemium Sep 19, 2024
15 of 18 checks passed
@aataraxiaa aataraxiaa deleted the pete/feature/pir-freemium-copy-updates branch September 19, 2024 15:04
aataraxiaa added a commit that referenced this pull request Oct 8, 2024
Task/Issue URL:
https://app.asana.com/0/1206488453854252/1208161235633546/f

**Description**: This PR updates the copy of Freemium DBP UI to match
the (nearly) final design copy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants