Send success pixel on successful data import #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mport-pixel-events
amddg44
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Tested out a whole bunch of imports and LGTM!
One small note, from the list of action cases bookmarks, passwords, favicons, generic I wasn’t able to trigger any bookmarks or passwords actions even when selecting import via html / csv file but perhaps I missed an import flow
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
|
This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions. |
graeme
added a commit
that referenced
this pull request
Nov 11, 2024
Task/Issue URL: https://app.asana.com/0/1203822806345703/1207768516988587/f **Description**: During [✓ Postmortem: Deduplicate passwords on import](https://app.asana.com/0/0/1207598056251596) it was mentioned that having insight on the rate of import success vs failure would be useful. We already have Pixels for failures but cannot calculate a success rate from that alone. This adds import success Pixels with source and make sure the failure Pixels and their source parameter are being sent properly. **Steps to test this PR**: 1. Run this with the debugger attached 2. Perform password / bookmark / favicon imports from all the import sources (or at least a sensible subset) 3. Check that, on successful import, the pixel: m_mac_data-import-succeeded_{action}_{source} is sent <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
samsymons
added a commit
that referenced
this pull request
Nov 12, 2024
# By Dax the Duck (5) and others # Via GitHub (3) and Juan Manuel Pereira (1) * main: Remediate TunnelVision, TunnelCrack and fix "Exclude Local Networks" (#3422) Sync: Send pixels for account removal + decoding issues (#3530) Send success pixel on successful data import (#3437) Bump version to 1.114.0 (304) Set marketing version to 1.114.0 Update embedded files Introduce report broken site prompt on triple refresh page (#3523) add state for import (#3485) Bump version to 1.113.0 (303) Do not use suggestion view controller visibility to set suggestion (#3529) Fix SwiftLint Fix SwiftLint Update phishing protection datasets to 1686837 (#3494) Bump version to 1.113.0 (302) Update permission string for location popup (#3526) Send auth state with sync unexpectedly disabled pixel (#3521) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203822806345703/1207768516988587/f
Description:
During ✓ Postmortem: Deduplicate passwords on import it was mentioned that having insight on the rate of import success vs failure would be useful.
We already have Pixels for failures but cannot calculate a success rate from that alone.
This adds import success Pixels with source and make sure the failure Pixels and their source parameter are being sent properly.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation