Fix add to favorites and open in new tabs action not working on manager #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaemepereira
force-pushed
the
juan/fix-actions-bookmarks-manager
branch
from
91de7ce to
eafc371
Compare
mallexxx
approved these changes
Oct 31, 2024
samsymons
added a commit
that referenced
this pull request
Nov 6, 2024
…tatus # By Dominik Kapusta (1) and Juan Manuel Pereira (1) # Via GitHub * main: Fix add to favorites and open in new tabs action not working on manager (#3467) Update C-S-S to 6.29.0 (#3515) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Nov 6, 2024
# By Dominik Kapusta (4) and others # Via Dominik Kapusta (1) and others * main: Update Ruby to 3.3.4 (#3519) Fix UI tests failing (#3517) Add menu option to set as default browser (#3508) Bump version to 1.113.0 (300) Deprecate PixelKit daily pixel suffixes (#3509) Update permission usage description strings in Info.plist (#3518) Fix add to favorites and open in new tabs action not working on manager (#3467) Hiding of tab previews for pinned tabs fixed (#3513) Update C-S-S to 6.29.0 (#3515) Freemium PIR: Ship Review Changes - Updated New Tab Banner UI (#3501) Send pixel on sync secure storage read failure (#3497) Remove com.apple.security.device.usb entitlement (#3495) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Nov 6, 2024
# By Dominik Kapusta (4) and others # Via Dominik Kapusta (1) and others * main: VPN clean-up (#3474) Update Ruby to 3.3.4 (#3519) Fix UI tests failing (#3517) Add menu option to set as default browser (#3508) Bump version to 1.113.0 (300) Deprecate PixelKit daily pixel suffixes (#3509) Update permission usage description strings in Info.plist (#3518) Fix add to favorites and open in new tabs action not working on manager (#3467) Hiding of tab previews for pinned tabs fixed (#3513) Update C-S-S to 6.29.0 (#3515) Freemium PIR: Ship Review Changes - Updated New Tab Banner UI (#3501) Send pixel on sync secure storage read failure (#3497) Remove com.apple.security.device.usb entitlement (#3495) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Nov 7, 2024
# By Dominik Kapusta (4) and others # Via Dominik Kapusta (1) and others * main: Remove VPN test rollout pixel (#3510) VPN clean-up (#3474) Update Ruby to 3.3.4 (#3519) Fix UI tests failing (#3517) Add menu option to set as default browser (#3508) Bump version to 1.113.0 (300) Deprecate PixelKit daily pixel suffixes (#3509) Update permission usage description strings in Info.plist (#3518) Fix add to favorites and open in new tabs action not working on manager (#3467) Hiding of tab previews for pinned tabs fixed (#3513) Update C-S-S to 6.29.0 (#3515) Freemium PIR: Ship Review Changes - Updated New Tab Banner UI (#3501) Send pixel on sync secure storage read failure (#3497) Remove com.apple.security.device.usb entitlement (#3495) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201048563534612/1208523846260390/f
Tech Design URL:
CC:
Description:
Fix add to favorites and open in new tabs action not working on the bookmark manager when selecting multiple bookmarks.
Steps to test this PR:
Open in New TabsAdd to favoritesDefinition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation